I am having problems with my homework:Write a function called valid_date that takes three positive integer scalar inputs year, month, day....

Question

Mileyka Bustamante 2020-5-19

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/527214-i-am-having-problems-with-my-homework-write-a-function-called-valid_date-that-takes-three-positive-i

评论： Abhishek Kumar 2021-5-30

I am trying the next code, and it run. But when i submit 'various inputs' failed, someone could help me please?

function valid = valid_date(year, month, day)
if (nargin == 3)
    if((isscalar(year) && isscalar(month) && isscalar(day)) && (year==fix(year) && month==fix(month) && day==fix(day)))
        if (rem(year,4)==0 && rem(year,100)~=0) || (rem(year,400)==0 && rem(year,100)~=0)
           if (ismember(month,[1,3,5,7,8,10,12]) && ismember(day,[1:31]))
            valid=true;
           elseif ismember(month,[2]) && ismember(day,[1:29])
            valid=true;
           elseif (ismember(month,[4,6,9,11]) && ismember(day,[1:30]))
            valid=true;
           else
            valid=false;
           end
        else
            if (ismember(month,[1,3,5,7,8,10,12]) && ismember(day,[1:31]))
                valid=true;
            elseif ismember(month,[2]) && ismember(day,[1:28])
                valid=true;
            elseif (ismember(month,[4,6,9,11]) && ismember(day,[1:30]))
                valid=true;
            else
                valid=false;
            end
        end  
    else
        valid=false;
    end
else
    valid= false;
end

3 个评论
显示 1更早的评论隐藏 1更早的评论

Stephen23 2020-5-20

"...But when i submit 'various inputs' failed,"

Can you provide us with the cases for which the test failed?

Abhishek Kumar 2021-5-30

在 MATLAB Online 中打开

% This is the working code
function [valid] = valid_date(y, m, d)
t = isscalar(y) && isscalar(m) && isscalar(d)
if t ~= 1
    valid = false;
else nargin == 3 && (y && m > 0) 
      
  p = rem(y,4);
  q = rem(y,100);
  r = rem(y,400);
  
  if (p == 0 && q ~= 0) || r == 0
      if (m == 1 || m == 3 || m == 5 || m == 7 || m == 8 || m == 10 || m == 12) && (d > 0 && d <= 31)
          valid = true;
      elseif (m == 4 || m == 6 || m == 9 || m == 11) && (d > 0 && d <= 30)
          valid = true;
      elseif m == 2 && (d > 0 && d <= 29)
          valid = true;
      else
          valid = false;
      end
  else
      if (m == 1 || m == 3 || m == 5 || m == 7 || m == 8 || m == 10 || m == 12) && (d > 0 && d <= 31)
          valid = true;
      elseif (m == 4 || m == 6 || m == 9 || m == 11) && (d > 0 && d <= 30)
          valid = true;
      elseif m == 2 && (d > 0 && d <= 28)
          valid = true;
      else
          valid = false;
      end
  end
  end

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

per isakson 2020-5-20

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/527214-i-am-having-problems-with-my-homework-write-a-function-called-valid_date-that-takes-three-positive-i#answer_434094

在 MATLAB Online 中打开

Replace

(rem(year,4)==0 && rem(year,100)~=0) || (rem(year,400)==0 && rem(year,100)~=0)

by

(rem(year,4)==0 && rem(year,100)~=0) || (rem(year,400)==0)

It looks like copy&paste error.

A small test

foo = @(year) (rem(year,4)==0 && rem(year,100)~=0) || (rem(year,400)==0 && rem(year,100)~=0);
>> foo(2000)
ans =
  logical
   0
>> foo(1900)
ans =
  logical
   0
>> leap = @(year) (rem(year,4)==0 && rem(year,100)~=0) || (rem(year,400)==0);
>> leap(1900)
ans =
  logical
   0
K>> leap(2000)
ans =
  logical
   1

IMO: Here is a function that is simpler to read and understand

function valid = valid_date_poi( year, month, day )
    % What is worst an early return or an if-statement that spans thirty lines of code?
    % I think it's ok to sometimes use early returns.
    % Copyright 2020 poi
    
    if not( nargin == 3 )
        valid = false;
        return                  %   RETURN
    end
    
    is_whole_number = @(num) rem(num,1) == 0; 
    if not( isscalar(year)     && is_whole_number(year)  && year  >= 0  ...
            && isscalar(month) && is_whole_number(month) && month >= 1  ...
            && isscalar(day)   && is_whole_number(day)   && day   >= 1  )
        valid = false;
        return                  %   RETURN
    end
    
    if month >= 13
        valid = false;
        return                  %   RETURN
    end
    
    if day > eomday( year, month )  % Search Documentation for "leap year"
        valid = false;
        return                  %   RETURN
    end
    
    valid = true;
end