Can you help me improve the code & speed of the nested for loop?

1 次查看（过去 30 天）

Mohammed 2014-9-22

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/155713-can-you-help-me-improve-the-code-speed-of-the-nested-for-loop

评论： Roger Stafford 2014-9-22

I wrote this part of the code this afternoon, it works fine but don't like it, any other options to write it a better way.

 SValAgree = zeros(lngPSCset,2);
for i=1:lngPSCset
    match = 0;
    for j=3:clmPSCset-3 
        for k=6:clmPSCset
            if PSCset(i,j) ~= 0 && PSCset(i,j) == PSCset(i,k)
                    match = match + 1; break; 
                else continue
            end
        end
    end
    ASValAgree(i,1) = match;
end

Thanks!!

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Roger Stafford 2014-9-22

Are you sure this code is doing you what you think it is? When j becomes 6 or greater in the second loop and PSCset(i,j) is nonzero, then a match is inevitable at the k which equals j, so there is no need to do all that comparing in the inner k-loop. For such a j, the code will always add 1 to 'match'.

请先登录，再进行评论。

请先登录，再回答此问题。