Global Variable calling error

Question

0 个投票

Hi, I have defined a function with global variables. I get the following message: "The left hand side is initialized and has an empty range of indices. However, the right hand side returned one or more results." In the main code, node is of char class, nindex is 0, Nodes=''

The function code:

function nodenumber=nodechecker(node)
global Nodes nindex
v=strcmp(Nodes,node);
indis=find(v,1);
if isempty(indis)==1
    nindex=nindex+1;
    Nodes{nindex}=node;
    nodenumber=nindex;
else
    nodenumber=indis;
end

2 个评论
显示无隐藏无

Adam 2014-11-25

This is one of the big flaws of using global variables. In a good design this function should be able to know all it needs to know about the variables that are within its workspace so it can validate them and know what to expect of them.

Having a global variable drop in that was defined somewhere else, can be changed anywhere else and at any time is not good practice.

Is there a reason why you can't just pass in Nodes and nindex as arguments to your function so that they have function-bounded scope?

Baki 2014-11-25

编辑：Baki 2014-11-25

The idea is already to update Nodes. If node string is not inside Nodes structure, add node to Nodes. I want Nodes to be structure or cell-array (whichever works)

请先登录，再进行评论。

请先登录，再回答此问题。

Follow Question