I want to loop for files in workspace

Question

Chuchu Debebe 2022-5-12

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/1717560-i-want-to-loop-for-files-in-workspace

评论： Chuchu Debebe 2022-5-13

Dear all,

I have a lot of data that I imported into my workspace. Let's say I have data1, data2,... and dataN in my workspace. For example, I want to get length(data1), length(data2),... and length(dataN) automatically using a loop. Do I have any way to do that?

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Stephen23 2022-5-12

"Let's say I have data1, data2,... and dataN in my workspace."

And that is the start of your problems: badly-designed data with pseudo-indices forced into the variable names. Accessing numbered variable names in a loop is one way that beginners force themselves into writing slow, complex, inefficient, buggy code that is difficult to debug:

https://www.mathworks.com/matlabcentral/answers/304528-tutorial-why-variables-should-not-be-named-dynamically-eval

Much better data design would use one array, then you could use simple and efficient indexing, just like MATLAB is designed for.

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Stephen23 2022-5-12

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/1717560-i-want-to-loop-for-files-in-workspace#answer_962550

在 MATLAB Online 中打开

"Let's say I have data1, data2,... and dataN in my workspace."

Lets assume that you did not name them all by hand, but instead that you LOADed them one-by-one from some MAT files. In which case, that is the correct place to fix the badly-designed data, e.g. renaming the variable in each MAT file to use exactly the same name, which would make it much easier to write simple, efficient, robust code to process your data.

Remember to always LOAD into an output variable!

If you cannot rename the MAT file vairiables and there is exactly one variable per MAT file, then we can LOAD them like this to avoid having lots of ugly numbered variable names in the workspace:

P = 'absolute or relative path to where the files are saved';
S = dir(fullfile(P,'*.mat'));
N = numel(S);
C = cell(1,N);
for k = 1:N
    F = fullfile(P,S(k).name);
    C(k) = struct2cell(load(F));
end
V = cellfun(@numel,C)

Simpler and much more efficient than trying to mess around with dynamic variable names.

7 个评论
显示 5更早的评论隐藏 5更早的评论

Chuchu Debebe 2022-5-12

编辑：Chuchu Debebe 2022-5-12

在 MATLAB Online 中打开

Sir,

This is some part of the code I am writing. I included your code and it solved many problems. The problem is that I am not the one who will select the extension, but it will be selected by the user. The following code will only work if the user enters mat in the command window; otherwise it will not work.

%%

close all

clc

My_directory=input('Pleas enter the address of the directory containing strong motion records: ','s');

% Here you are supposed to put your folder name in command window

% Note that the input should look like C:\Users\Kumsa\Desktop\OCM_MAT(for

% my case)

cd(My_directory);

disp('You are now in the directory containing the strong motion records')

extension=input('Please enter the extension of the record files: ','s');

% Please put proper input, for example, txt or mat.

ext_code =['','*.',extension,''];

directory_all=strcat([My_directory,'\'], ext_code);

%%

S = dir(directory_all);

P = pwd;

N = numel(S);

C = cell(1,N);

for i=1:N

F=fullfile(P,S(i).name);

C(i) = struct2cell(load(F));

end

Stephen23 2022-5-12

编辑：Stephen23 2022-5-13

在 MATLAB Online 中打开

Do not use CD to access data files. Changing directories to access data files is slow and makes debugging harder. You can always use absolute/relative filenames, just like I showed you (using FULLFILE).

"The following code will only work if the user enters mat in the command window; otherwise it will not work."

It will not work at all, because you replaced the k index with N, which makes the loop do nothing.

"The problem is that I am not the one who will select the extension, but it will be selected by the user."

There is nothing stopping you from importing different file types:

P = input('Pleas enter the address of the directory containing strong motion records: ','s');
E = input('Please enter the extension of the record files: ','s');
S = dir(fullfile(P,sprintf('*.%s',E)));
N = numel(S);
C = cell(1,N);
for k = 1:N
    F = fullfile(P,S(k).name);
    switch lower(E)
        case 'mat'
            C(k) = struct2cell(load(F));
        case 'xxx'
            C{k} = importwhatever(F);
        otherwise
            C{k} = readmatrix(F);
    end
end

Add more cases as required.

Stephen23 2022-5-13

@Chuchu Debebe: fixed now, try it again.

Chuchu Debebe 2022-5-13

Thank you, sir. It worked!!

请先登录，再进行评论。

Answer 2

KSSV 2022-5-12

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/1717560-i-want-to-loop-for-files-in-workspace#answer_962545

在 MATLAB Online 中打开

s = whos ; 
for i = 1:length(s)
    s(i).size
end

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

I want to loop for files in workspace

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

采纳的回答

7 个评论
显示 5更早的评论隐藏 5更早的评论

更多回答（1 个）

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

另请参阅

类别

标签

产品

版本

Community Treasure Hunt

I want to loop for files in workspace

1 个评论 显示 -1更早的评论隐藏 -1更早的评论

采纳的回答

7 个评论 显示 5更早的评论隐藏 5更早的评论

更多回答（1 个）

0 个评论 显示 -2更早的评论隐藏 -2更早的评论

另请参阅

类别

标签

产品

版本

Community Treasure Hunt

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

7 个评论
显示 5更早的评论隐藏 5更早的评论

0 个评论
显示 -2更早的评论隐藏 -2更早的评论