Splitting into function files

Question

Chris 2011-12-6

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/23172-splitting-into-function-files

clear 
clc
fid = fopen('hangman.txt','r');
if fid < 0,    error('Cannot open file');    end
data = textscan(fid,'%s');
data = data{1};
fclose(fid); 
index = ceil(rand * numel(data));
word = data{index};
masked = word; 
masked(~isspace(masked)) = '*';
complete = 0;
wrong=0;
while complete == 0
    clc;
    fprintf('Word : %s\n',masked);
    letter = char(input('Guess a letter : ','s'));
    stat = findstr(word,letter);
    if ~isempty(stat)
        masked(stat) = letter; 
    elseif ~isequal(word,letter)
        wrong=wrong+1; 
    end
    if isempty(findstr(masked,'*'))
        complete = 1;
        fail=0;
    end
    if wrong==6
        complete=1;
        fail=1;
    end    
end
if fail==0
    clc; fprintf('You win, the word is : %s\n',masked);
elseif fail==1
    disp('You lose')
end

My Professor wants me to split this into multiple function files, I'm not entirely sure how he wants me to accomplish that.

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Chandra Kurniawan 2011-12-6

1
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/23172-splitting-into-function-files#answer_30487

在 MATLAB Online 中打开

Just call the function's name.

I will give U first sample code :)

Replace code below :

fid = fopen('hangman.txt','r');
if fid < 0,    error('Cannot open file');    end
data = textscan(fid,'%s');
data = data{1};
fclose(fid);

with :

filename = 'Hangman.txt';
data = load_data(filename);

Now, create a m-file then type this code :

function data = load_data(filename)
fid = fopen(filename,'r');
if fid < 0,    
    error('Cannot open file');    
end
data = textscan(fid,'%s');
data = data{1};
fclose(fid);

Save the code above with filename : 'load_data.m'.

And try to run your code modified now.

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Chandra Kurniawan 2011-12-6

@Chris : Hi,

Would you finish the rest with your own ideas? :)

You said that your professor want to divide it into multiple files.

I have suggested you that your code can be divide into 5 function file as my version.

So, I hope my suggestion would helps you :)

请先登录，再进行评论。

Answer 2

Chandra Kurniawan 2011-12-6

1
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/23172-splitting-into-function-files#answer_30436

在 MATLAB Online 中打开

Hello, Chris

Was your professor wants to divide or split this code into multiple function files?

I have tried with my own code,

and I can divide it into 5 function files.

1] load_data.m  => function data = load_data(filename)
2] select_word.m  => function [word masked] = select_word(data)
3] update.m  => function [masked letter_guessed wrong]= update(word, masked, wrong, letter_guessed, letter)
4] check_win  => function [complete fail] = check_win(masked, wrong)
5] display_message => function display_message(fail, masked)

And I have main file that named 'main.m'. So, totally I have 6 m-files.

3 个评论
显示 1更早的评论隐藏 1更早的评论

Matt Tearle 2011-12-6

"Open"? Do you mean how to use/call the functions from the main file? Just like you would with any MATLAB function. So it looks like Chandra has moved lines 3 - 7 into the load_data function. This function takes a filename as input and returns data as an output. Hence, in the main code, lines 3 - 7 would be replaced with a single call to load_data:

data = load_data('hangman.txt');

Chandra Kurniawan 2011-12-6

@Matt : You are right :)

请先登录，再进行评论。

Answer 3

Chandra Kurniawan 2011-12-6

1
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/23172-splitting-into-function-files#answer_30499

在 MATLAB Online 中打开

Hello,

After modification, I get my code becomes shorter :

clear, clc;
filename = 'Hangman.txt';
data = load_data(filename);
[word masked] = select_word(data);
complete = 0;    wrong = 0;
letter_guessed = '';
while complete == 0
  clc;  fprintf('%d letters word\n', length(word));
  fprintf('Letter guessed : %s\n',letter_guessed);
  letter = char(input('Guess a letter : ','s'));
  [masked letter_guessed wrong]= update(word, masked, wrong, letter_guessed, letter);  
  [complete fail] = check_win(masked, wrong);
end
display_message(fail, masked);

But you need to build 5 functions.

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Chris 2011-12-6

That is my entire code so far. I called in 2 functions. I still do not understand how you called in the while loop and the if and else if statements after the while loop. -_-

%Clears all data from previous program

clear

clc

%Calls function (opens text file)

filename = 'Hangman.txt';

data = load_data(filename);

%Calls the function (random)

[word masked] = select_word(data);

complete = 0;

wrong=0;

letter_guessed = '';

while complete == 0

fprintf('Word : %s\n',masked);

letter = char(input('Guess a letter : ','s'));

stat = findstr(word,letter);

if ~isempty(stat)

masked(stat) = letter;

letter_guessed = strcat(letter_guessed,letter);

elseif ~isequal(word,letter)

wrong=wrong+1;

end

if isempty(findstr(masked,'*'))

complete = 1;

fail=0;

end

if wrong==6

complete=1;

fail=1;

end

if fail==0

fprintf('You win, the word is : %s\n',word);

elseif fail==1

fprintf('You lose, the word was : %s\n',word);

end

ORIGINAL CODE

%Clears all data from previous program

clear

clc

%Calls function

filename = 'Hangman.txt';

data = load_data(filename);

%Chooses a random word from text file

index = ceil(rand * numel(data));

%Makes word not case sensitive

word = lower(data{index});

masked = word;

%Replaces characters with astferisks

masked(~isspace(masked)) = '*';

complete = 0;

wrong=0;

letter_guessed = '';

while complete == 0

fprintf('Word : %s\n',masked);

letter = char(input('Guess a letter : ','s'));

stat = findstr(word,letter);

if ~isempty(stat)

masked(stat) = letter;

letter_guessed = strcat(letter_guessed,letter);

elseif ~isequal(word,letter)

wrong=wrong+1;

end

if isempty(findstr(masked,'*'))

complete = 1;

fail=0;

end

if wrong==6

complete=1;

fail=1;

end

if fail==0

fprintf('You win, the word is : %s\n',word);

elseif fail==1

fprintf('You lose, the word was : %s\n',word);

end

请先登录，再进行评论。

Answer 4

Chandra Kurniawan 2011-12-6

1
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/23172-splitting-into-function-files#answer_30504

在 MATLAB Online 中打开

I will give you one more.

function [complete fail] = check_win(masked, wrong)
   if isempty(findstr(masked,'*'))
        complete = 1;      fail = 0;
   elseif wrong >= 6
        complete = 1;       fail = 1;
   else
       complete = 0;       fail = 0;
   end

Now, you have 3 function files.

See my shorten main file.

So, now you can replace

   if isempty(findstr(masked,'*'))
        complete = 1;
        fail=0;
    end
    if wrong==6
        complete=1;
        fail=1;
    end

with :

[complete fail] = check_win(masked, wrong);

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

Splitting into function files

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

采纳的回答

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

更多回答（3 个）

3 个评论
显示 1更早的评论隐藏 1更早的评论

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

另请参阅

类别

标签

Community Treasure Hunt

Splitting into function files

0 个评论 显示 -2更早的评论隐藏 -2更早的评论

采纳的回答

1 个评论 显示 -1更早的评论隐藏 -1更早的评论

更多回答（3 个）

3 个评论 显示 1更早的评论隐藏 1更早的评论

1 个评论 显示 -1更早的评论隐藏 -1更早的评论

0 个评论 显示 -2更早的评论隐藏 -2更早的评论

另请参阅

类别

标签

Community Treasure Hunt

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

3 个评论
显示 1更早的评论隐藏 1更早的评论

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

0 个评论
显示 -2更早的评论隐藏 -2更早的评论