return doesn't work within function

Question

Jonas Thomalla 2020-11-10

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/643340-return-doesn-t-work-within-function

评论： Walter Roberson 2020-11-10

采纳的回答： Matt J

在 MATLAB Online 中打开

Hi,

I've created a function that should cancel the base script. I call the function with the following code:

if isempty(factor.editingImages.fillHoles) == true
    scriptFailed('Failure during selection of fill-threshold.');
end

And this is the function:

function [] = scriptFailed(failureText)
%scriptFailed saves the current workspace and displays a message
%   The message can be defined by failureText (string-variable)
filename = [datestr(now,'yyyy-mm-dd,HH.MM.SS'),' canceledWorkspace.mat'];
evalin('base',sprintf('save(''%s'')',fullfile(pwd,filename)))
disp([failureText,' The programm canceled and saved the workspace ("',filename,'").'])
close all
return
end

But after calling the function (workspace is always created as it should be, so the function is always active), the next lines after the if-loop are trying to do something but can't, because there are some variables missing. Why does return doesn't cancel the running script?

Thanks for your help!

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Matt J 2020-11-10

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/643340-return-doesn-t-work-within-function#answer_540245

编辑：Matt J 2020-11-10

在 MATLAB Online 中打开

You cannot give a function the power to abort another function. See also,

https://www.mathworks.com/matlabcentral/answers/576610-evalin-cannot-execute-a-return?s_tid=srchtitle

Your code should look like this, instead:

if isempty(factor.editingImages.fillHoles) == true
    scriptFailed('Failure during selection of fill-threshold.');
    return
end
function [] = scriptFailed(failureText)
%scriptFailed saves the current workspace and displays a message
%   The message can be defined by failureText (string-variable)
    filename = [datestr(now,'yyyy-mm-dd,HH.MM.SS'),' canceledWorkspace.mat'];
    evalin('base',sprintf('save(''%s'')',fullfile(pwd,filename)))
    disp([failureText,' The programm canceled and saved the workspace ("',filename,'").'])
    close all
end

6 个评论
显示 4更早的评论隐藏 4更早的评论

Matt J 2020-11-10

No, see my edited answer. You can abort the current script as long as you call return in the workspace of that script.

Jonas Thomalla 2020-11-10

I put it at the end of the function because I thought it would also stop execution the script above. I have several conditions that are calling this function and should stop the whole script. Then I could've let return within the function. Now I'm taking your variant and put it everywhere right after calling the function.

Thank you for your help!

请先登录，再进行评论。

Answer 2

Steven Lord 2020-11-10

1
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/643340-return-doesn-t-work-within-function#answer_540305

Why does return doesn't cancel the running script?

It does exit from the currently running function. It exits the scriptFailed function, returning control to the script or function that called scriptFailed.

To do what you want, either:

move the return keyword from inside scriptFailed to just after scriptFailed is called in its caller. Note that if scriptFailed itself was called from a function, it will return back to control of its caller.
Have scriptFailed throw an error indicating the problem. Unless something higher up in the caller stack is running this code in the try section of a try / catch block the error will work its way up through the caller stack and eventually cause the top-level script or function to exit. Even if something higher in the caller stack does try / catch the error, it can rethrow the error once it has performed whatever cleanup or error handling it needs to perform.

3 个评论
显示 1更早的评论隐藏 1更早的评论

Steven Lord 2020-11-10

在 MATLAB Online 中打开

While I wrote them in that order because I thought of them in that order, in the situation you described I'd prefer the second. Something fatal to the execution of your program occurred, something from which it cannot recover. Having the code throw an error will indicate that the code was unsuccessful in a way that's harder for your user to ignore than a simple displayed message. The red text in the Command Window tends to stand out. Compare:

if 1+1 ~= 3
    disp('Incorrect answer')
end
Incorrect answer

versus

if 1+1 ~= 3
    error('Incorrect answer')
end
Incorrect answer

Which catches your eye more quickly?

Walter Roberson 2020-11-10

If you are using functions and you need to go back up through multiple levels without the function returning its usual value, then you should be using error() . error() can head back up the call stack until it encounters a catch block, and it does not require that each function along the way return anything at all.

请先登录，再进行评论。