The goal of the function is entirely unclear.
There are several critical problems that need to be addressed.
- What is locations? It appears in the 2nd line and is never defined. This should throw an error unless locations is a global variable but a function should not rely on global variables.
- spectrum3 should probably be named spectrum2. Otherwise, spectrum2 is never defined and spectrum3 is never used.
Some less critical but noteworthy issues:
- findpeaks is the name of a matlab function. Rename this function to avoid confusion and shadow problems.
- Instead of preallocating with rand(), why not use nan(), ones(), or zeros()?
- Instead of using length(), use numel(). What if a user enters an array that isn't a vector?
- The j-loop can be vectorized by using indexing if not eliminated complete (see critical list above).
