Adding a counter to a loop

Question

Mohammad Dabbagh 2021-6-23

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/863030-adding-a-counter-to-a-loop

评论： Mathieu NOE 2021-6-24

采纳的回答： Mathieu NOE

在 MATLAB Online 中打开

Hi there,

I was wondering if anyone could do me a favor and let me know why my added counters blow does not work!

Thak you so much in advance.

for time = 1 : 8760
    CountWintW=0;
    CountWintE=0;
    CountWintS=0;
    CountWintN=0;
    
    for WinNum=1:4
        if AbsRad(time,WinNum) >= 0.0001
            NewSHGC(WinNum) = shgc.open;
            NewWinR(WinNum) = 1/U_factor.open;
        else
            NewSHGC(WinNum) = shgc.close;
            NewWinR(WinNum) = 1/U_factor.close;
            
            if WinNum ~=1
                CountWintW = CountWintW+1;
            elseif WinNum ~=2
                CountWintE = CountWintE+1;
            elseif WinNum ~=3
                CountWintS = CountWintS+1;
            elseif WinNum ~=4
                CountWintN = CountWintN+1;
            end
        end
    end
end

3 个评论
显示 1更早的评论隐藏 1更早的评论

Rik 2021-6-23

在 MATLAB Online 中打开

You clearly didn't try running your code line by line with the debugger.

If you had done so, you would have spotted 2 issues:

every time step you're resetting the counters
because you're using ~=, the third option will never be reached (if WinNum is 1 the second counter will increment, if WinNum is any value not equal to 1 the first counter will increment)

It also looks like it would make sense to use a vector and use WinNum as the index:

CountWin=zeros(1,4);
for time = 1 : 8760
    [...]
    CountWin(WinNum)=CountWin(WinNum)+1;

Mohammad Dabbagh 2021-6-24

Thank you so much, Rik!

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Mathieu NOE 2021-6-23

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/863030-adding-a-counter-to-a-loop#answer_731270

在 MATLAB Online 中打开

hello

IMHO, the initialisation of the counters should be done BEFORE the first for loop

    CountWintW=0;
    CountWintE=0;
    CountWintS=0;
    CountWintN=0;
for time = 1 : 8760
    
    for WinNum=1:4
        if AbsRad(time,WinNum) >= 0.0001
            NewSHGC(WinNum) = shgc.open;
            NewWinR(WinNum) = 1/U_factor.open;
        else
            NewSHGC(WinNum) = shgc.close;
            NewWinR(WinNum) = 1/U_factor.close;
            
            if WinNum ~=1
                CountWintW = CountWintW+1;
            elseif WinNum ~=2
                CountWintE = CountWintE+1;
            elseif WinNum ~=3
                CountWintS = CountWintS+1;
            elseif WinNum ~=4
                CountWintN = CountWintN+1;
            end
        end
    end
end