How to solve :'Error using prod. Invalid data type. First argument must be numeric or logical.'

Question

zahra rashidi 2022-3-7

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/1665804-how-to-solve-error-using-prod-invalid-data-type-first-argument-must-be-numeric-or-logical

评论： Walter Roberson 2022-3-8

采纳的回答： Walter Roberson

在 MATLAB Online 中打开

Hi,

In this part of the code:

--------------------------------------

if (prod(children(Term(ll)))~=Term(ll))
    AAA=size(children(Term(ll)));
    Chi(ll,1:AAA(1,2))=children(Term(ll));
    Chi(ll,:)=expand(Chi(ll));
else
    AAA=[1 1];
    Chi(ll,1:1)=Term(ll);     
end

---------------------------------------

I get the following error:

---------------------------------------

Error using prod

Invalid data type. First argument must be numeric or logical.

Error in Generalized_Integration_Code (line 130)

if (prod(children(Term(ll)))~=Term(ll))

----------------------------------------

Can you please help me how can I solve the error?

Thanks

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Walter Roberson 2022-3-7

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/1665804-how-to-solve-error-using-prod-invalid-data-type-first-argument-must-be-numeric-or-logical#answer_912369

编辑：Walter Roberson 2022-3-7

在 MATLAB Online 中打开

https://www.mathworks.com/help/symbolic/sym.children.html

"Starting in R2020b, the syntax subexpr = children(expr) for a scalar input expr returns subexpr as a nonnested cell array instead of a vector"

So you will need to replace

prod(children(Term(ll)))

with

prod([struct('T',children(Term(ll))).T{:}])

Or previously construct

symcell2mat = @(v) [v{:}]

with

prod(symcell2mat(children(Term(ll))))

8 个评论
显示 6更早的评论隐藏 6更早的评论

Walter Roberson 2022-3-7

编辑：Walter Roberson 2022-3-7

在 MATLAB Online 中打开

[struct('T',children(Term(ll))).T]

is a syntax "cheat" in MATLAB.

children() in what you are doing is returning a cell array of symbolic expressions.

In order to use that with prod(), you need to turn the cell array of symbolic expressions into a vector of symbolic expressions.

If this were numeric work you were doing, then the easiest way to turn a cell array of numeric values into a vector is to use cell2mat(). Unfortunately, cell2mat() does not support symbolic expressions.

cell2mat() is a convenience routine that can handle non-scalars, but in this particular case of a row vector of values, cell2mat(X) effectively executes [X{:}] which is also known as horzcat(X{:}] . The {:} part means to do "cell expansion" -- the effect is the same as-if at that point the user had written out X{1},X{2}, X{3} all the way to the last entry. So [X{:}] is the same as [X{1},X{2},X{3},...X{end}] . And cell2mat() does that nicely in a clearly-named manner for numeric values, but cell2mat() refuses to work for symbolic expressions even though the same [X{:}] is all that would be needed.

You might hope that you could do

[children(Term(ll)){:}]

but MATLAB does not permit {:} indexing of the result of a function call.

So... at this point you have several choices to convert the cell array into a vector:

A) You can write out the code by hand, in long form:

TermChildren = children(Term(ll));
if prod([TermChildren{:}]) ~= Term(ll)

This requires at least one assignment to a temporary variable.

B) You can define an extra function such as

symcell2mat = @(v) [v{:}]

after which anywhere you wanted to convert a cell array of symbolic expressions into a vector of symbolic expressions you can call upon symcell2mat, like

if prod(symcell2mat(children(Term(ll)))) ~= Term(ll)

This kind of auxillary helper function is very useful, and can make code clearer -- but some people have trouble understanding using helper functions, and do not like to do that.

C) You can use the official MATLAB syntax for doing in-line expansion:

        if prod([subsref(children(Term(ll)), struct('type', '{}', 'subs', {':'}))]) ~= Term(ll)

This is supported syntax based upon the way that indexing is implemented. But it is clearly ugly and confusing and tricky to remember the details of

D) You can use a syntax cheat. I mentioned above that MATLAB does not permit {:} of the results of a function call. But it does permit {:} indexing of a struct field, and it permits struct field indexing of the result of a function call. So if you have a function call FUN(X) and you want to index the results, then instead of using complicated subref(), you can use struct() to match the results of FUN(X) with a field name, and then you can use the fact that structs returned from functions can be field indexed. Thus

if prod([struct('T',children(Term(ll))).T{:}]) ~= Term(ll)

means to execute children(Term(ll)) and wrap it inside a struct with field name T, and then make use of the fact that you can struct index the results of a function call to pull out the T field. Then when you have the T field (which is just the result of the children() call) you can use {:} indexing on it and [] around that {:} indexing so that you end up with a vector of symbolic expressions; which you can then prod().

I do not recommend this approach. I only use it when it is momentarily important to prove that it can be done, or else when it feels too complicated at the time to explain to the person that they should split up the calculations into multiple lines or learn how to use helper functions.

zahra rashidi 2022-3-8

You are great. Thanks a lot

Walter Roberson 2022-3-8

The case where the product of the children is not equal to the original is simply the case where the original item is not a product. Which is something that could be tested using isSymType testing for numbers or variables or 'times'.

请先登录，再进行评论。

Answer 2

Matt J 2022-3-7

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/1665804-how-to-solve-error-using-prod-invalid-data-type-first-argument-must-be-numeric-or-logical#answer_912194

在 MATLAB Online 中打开

We've no way of running your code, but I'm pretty certain if you just examine,

K>> class(children(Term(ll)))

all will be clear.

10 个评论
显示 8更早的评论隐藏 8更早的评论

zahra rashidi 2022-3-8

Thank you.

Walter Roberson 2022-3-8

Mathworks changed the output of children() to make the output for scalar input more consistent with the output for non-scalar input. Both cases now return cell array.

请先登录，再进行评论。

How to solve :'Error using prod. Invalid data type. First argument must be numeric or logical.'

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

采纳的回答

8 个评论
显示 6更早的评论隐藏 6更早的评论

更多回答（1 个）

10 个评论
显示 8更早的评论隐藏 8更早的评论

另请参阅

类别

标签

Community Treasure Hunt

How to solve :'Error using prod. Invalid data type. First argument must be numeric or logical.'

0 个评论 显示 -2更早的评论隐藏 -2更早的评论

采纳的回答

8 个评论 显示 6更早的评论隐藏 6更早的评论

更多回答（1 个）

10 个评论 显示 8更早的评论隐藏 8更早的评论

另请参阅

类别

标签

Community Treasure Hunt

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

8 个评论
显示 6更早的评论隐藏 6更早的评论

10 个评论
显示 8更早的评论隐藏 8更早的评论