My while loop will not stop even when it no longer meets the requirements, how do I fix this?

Question

Matthew Smyth 2022-4-19

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/1699840-my-while-loop-will-not-stop-even-when-it-no-longer-meets-the-requirements-how-do-i-fix-this

回答： Geoff Hayes 2022-4-19

I am coding a hangman, im using a while loop in here. The code for that is:

while ~(guessesLeft <= 0) || ~(correctCount == length(guessingWord-1))
    incorrectCount1=0;
    currentNum=0;
    NewGuess=input('Please enter your guess: ','s');
    for i=1:length(Guess)
        if NewGuess==guessingWord(i)
            Guess(i)=NewGuess;
            lettersLeft=lettersLeft-1;
            currentNum=currentNum+1;
            
            correctCount=correctCount+1;       
        else
            incorrectCount1=incorrectCount1+1;
        end
    end
    
    if currentNum==0
        fprintf('Your letter is not in the word!\n');
        guessesLeft=guessesLeft-1;
    else
        fprintf('You have made a correct guess!\n');
    end
    disp(Guess);
    
end

2 个评论
显示无隐藏无

Matt J 2022-4-19

Please demonstrate the problem.

Matthew Smyth 2022-4-19

Hi I managed to figure out both conditions work on their own, but the first condition does not work when the || or symbol is there, is there an issue here?

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Geoff Hayes 2022-4-19

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/1699840-my-while-loop-will-not-stop-even-when-it-no-longer-meets-the-requirements-how-do-i-fix-this#answer_945915

在 MATLAB Online 中打开

@Matthew Smyth - look closer at your while loop condition

while ~(guessesLeft <= 0) || ~(correctCount == length(guessingWord-1))

The loop will continue so long as the user still has guesses left OR hasn't selected the correct letters. I think that this should be an AND else you will have the problem where the user has used up all of their guesses but the other condition is still true. Also, it isn't clear (to me) why you are comparing the correct count with the length of the guessing word less one character. I think that the conditions should be more like

while guessesLeft > 0 && correctCount != length(guessingWord)