Using function in a serial code
显示 更早的评论
I have a function shown below:
function [ncell,phis,vac,nccel,ccell] = micro_poly_cell(Nx,Ny,ncell,R)
format long;
phis =zeros(Nx,Ny,ncell);
ncell == 2;
nccel = 0;
ccell(1)=0;
R2 = R*R;
xc(1,1)=70.0;
yc(1,1)=100.0;
xc(1,2)=130.0;
yc(1,2)=100.0;
ncol=1;
nrow=2;
icell =0;
for icol=1:ncol
for irow=1:nrow
icell = icell+1;
dx = xc(icol,irow);
dy = yc(icol,irow);
for i=1:Nx
for j=1:Ny
if((i- dx)*(i-dx) + (j-dy)*(j-dy) < R2)
phis(i,j,icell) =0.999;
end
end
end
end
end
vac(1) = 0.5;
vac(2) =-0.5;
end
It is called in a program as
...
[ncell,phis,vac,nccel,ccell] = micro_poly_cell(Nx,Ny,ncell,R);
...
I have written a new program. I have removed the first and last line of this function and have put the rest of the code in it. The problem is that the output is not the same as with the first program where function is called in a program. So how to correct it?
采纳的回答
Rik
2022-4-25
0 个投票
If you insert the body of this function in a different function, you essentially convert this into a script.
The downside of a script is that it shares the workspace with the caller, which means the code can no longer assume a clean workspace. If the code isn't written carefully, that means it can be affected by the code in the caller.
So the answer is: don't. Leave this a function and call it as a function. That way you have encapsulated behavior that is testable and repeatable. If one day you decide to improve the function, you only need to keep input and output the same and you can be certain everything still works.
The function you poseted contains not a single comment. You should start there. Make sure other people can use your function with only the help text at the top. Include comments in every section of your code that explains what is happening and why. It is also a mystery why this function sets a specific format, without actually printing anything.
4 个评论
Robert101
2022-4-25
Rik
2022-4-25
OK, and what should I do with them? My advice doesn't change.
Is there anything unclear to you from my answer?
Robert101
2022-4-25
I suspect the problem is that some variable is used in the preceding code, while the function presumes it doesn't exist.
disp(clean_workspace) % created in empty workspace
disp(polluted_workspace) % created in used workspace
function vac=clean_workspace
vac(2)=3;
end
function vac=polluted_workspace
vac=rand(1,5);%set a value in other code
vac(2)=3;
end
See? Twice the same code, but the results are different. This could have been prevented by making the assumption explicit:
vac=zeros(1,2);
vac(2)=3;
The best solution is to never work with scripts for real work. Only use it for debugging/writing. A function allows encapsulation. It helps you keep your workspace clean and allows treating parts of the process as a black box.
更多回答（0 个）
类别
在 帮助中心 和 File Exchange 中查找有关 Characters and Strings 的更多信息
Translated by 
