Efficient code for multiple string replace

Question

0 个投票

Hello,

I am attempting to replace substrings and evaluate equations for a large number of lines. The following code works for what I want:

% Define sets:
sec = ["T", "N"];  co = ["H","F"];         
nco = numel(co); nsec = numel(sec); 
for cc = 1:numel(co); 
    for ss = 1:numel(sec);
        eval(replace(['tau_payr_#S_#C_bar = 1; '],["#S","#C"], [sec(ss),co(cc)]));
        eval(replace(['tau_pinv_#S_#C_bar = 2; '],["#S","#C"], [sec(ss),co(cc)]));
        eval(replace(['tau_payr_#S_#C = tau_payr_#S_#C_bar; '],["#S","#C"], [sec(ss),co(cc)]));
        eval(replace(['tau_pinv_#S_#C = tau_pinv_#S_#C_bar; '],["#S","#C"], [sec(ss),co(cc)]));
    end;
end; 

I am wondering whether there's a better way to write this, where I don't have to write eval and replace at each line.

Thanks,

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

Follow Question

Answer 1

Voss 2023-2-2

在 MATLAB Online 中打开

0 个投票

You can store all those variables in a structure, and use dynamic field names.

sec = ["T", "N"];  co = ["H","F"];         
nco = numel(co); nsec = numel(sec); 
S = struct();
for cc = 1:numel(co)
    for ss = 1:numel(sec)
        payr_name = sprintf('tau_payr_%s_%s',sec(ss),co(cc));
        pinv_name = sprintf('tau_pinv_%s_%s',sec(ss),co(cc));
        S.([payr_name '_bar']) = 1;
        S.([pinv_name '_bar']) = 2;
        S.(payr_name) = S.([payr_name '_bar']);
        S.(pinv_name) = S.([pinv_name '_bar']);
    end
end
S
S = struct with fields:
    tau_payr_T_H_bar: 1
    tau_pinv_T_H_bar: 2
        tau_payr_T_H: 1
        tau_pinv_T_H: 2
    tau_payr_N_H_bar: 1
    tau_pinv_N_H_bar: 2
        tau_payr_N_H: 1
        tau_pinv_N_H: 2
    tau_payr_T_F_bar: 1
    tau_pinv_T_F_bar: 2
        tau_payr_T_F: 1
        tau_pinv_T_F: 2
    tau_payr_N_F_bar: 1
    tau_pinv_N_F_bar: 2
        tau_payr_N_F: 1
        tau_pinv_N_F: 2

See: https://www.mathworks.com/help/matlab/matlab_prog/generate-field-names-from-variables.html

2 个评论
显示无隐藏无

Abeer Reza 2023-2-2

okay, this is brilliant!! I guess I didn't understand some of the points in the link shared earlier.

Thanks :-)

Voss 2023-2-2

You're welcome! Glad it helps.

请先登录，再进行评论。

Answer 2

Walter Roberson 2023-2-2

0 个投票

If you are going to write something like that, then you should write it in the clearest way you can come up with, because you are going to end up spending a lot of time staring at the code when it fails to work the way you expect.

Please read http://www.mathworks.com/matlabcentral/answers/304528-tutorial-why-variables-should-not-be-named-dynamically-eval for information about why we strongly recommend against creating variable names dynamically.

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Abeer Reza 2023-2-2

I totally agree with how difficult it is to read this blasted code. The issue is that for my purpose, the variable name is very important. I need a method to dynamically generate variable names with letter suffixes not as an interim calculation step or to use as a placeholder, but as the final product.

Although I totally agree with the points made in the link you shared (thanks for that, btw), saving calculated values in arrays or structures improve code efficiency unfortunately does not serve my current purpose.

I'm no fan of eval or the replace commands, but I am not sure what else can be used to generate the variable names as above.

The only other idea I have is to use the loops and the replace commands to generate a new .m file which can be run independently (not using eval).

Any other suggestions or advice on whether the last idea is any good?

请先登录，再进行评论。

Efficient code for multiple string replace

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

采纳的回答

2 个评论
显示无隐藏无

更多回答（1 个）

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

类别

标签

Community Treasure Hunt

Efficient code for multiple string replace

0 个评论 显示 -2更早的评论 隐藏 -2更早的评论

采纳的回答

2 个评论 显示 无 隐藏 无

更多回答（1 个）

1 个评论 显示 -1更早的评论 隐藏 -1更早的评论

类别

标签

另请参阅

Community Treasure Hunt

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

2 个评论
显示无隐藏无

1 个评论
显示 -1更早的评论隐藏 -1更早的评论