Very slow function, excessive overhead?

4 次查看（过去 30 天）
Jesse
Jesse 2023-3-27
评论： Walter Roberson 2023-3-28
I've got a function that looks at a n x 2 array (1st column time vector, 2nd column flag vector) and it's running incredibly slow. As you can see, line 17 takes almost all of the runtime. I've read that this could be related to overhead, but I don't actually know what that means or how to improve it. Any ideas on what could be causing this?

请先登录，再回答此问题。

采纳的回答

Walter Roberson
Walter Roberson 2023-3-27
You are not assigning to flag within your loop, so you should use
flagrows = size(flag,1);
while i < flagrows
end
The end for a loop does get "charged" the cost of the loop overhead, which in this case is doing more computations than required.
  2 个评论
Jesse
Jesse 2023-3-27
Thank you! That did the trick. I didn't realize how computationally heavy the "size" function could be. It makes sense though, when you call it nearly 400 thousand times.
Walter Roberson
Walter Roberson 2023-3-28
you used length(flag(:, 1)) which starts by extracting the first column and then taking the length of the column. That sequence involves copying data and then checking the size. That is a lot more work then just checking the size of the original data.

请先登录，再进行评论。

更多回答（1 个）

Torsten
Torsten 2023-3-27
编辑：Torsten 2023-3-27
The inner while loop is not necessary: if flag(i,2)-flag(i-1,2) == 1, then of course flag(i,2)-flag(i-1,2) ~== -1. Thus the incrementation i = i+1 will always happen. This is strange since you increment i again after you quit the if-clause.
Preallocating "events" as zeros(size(flag,1),3) and finally cutting it by events = events(1:j-1,:) might speed up the function also.
  1 个评论
Jesse
Jesse 2023-3-27
I'm trying to find the start and end point of each flag "event". the outer loop finds when flag goes from 0 to 1, and the inner loop finds whent the flag goes from 1 to 0.

请先登录，再进行评论。

类别

在 Help Center 和 File Exchange 中查找有关 Loops and Conditional Statements 的更多信息

标签

产品


版本

R2019a

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by