Saving to a vector
显示 更早的评论
function [ b ] = PrimeF( x )
for i=1:x
if mod(x,i)==0
b=i;
end
end
b=isprime(b)*b;
end
I have built a simple function the return the prime factorization of a number. but I can find a way to save them into a vector I called b (that I do not know his size). Thanks
采纳的回答
Doing this in a loop and concatenating new values into a vector is very poor use of MATLAB, and will be very slow. It would be much better to learn how to write fully vectorized code, which will be much faster, neater and less buggy. Rather than learning bad coding habits and trying to change them later, you should learn from the very start how to write vectorized code in MATLAB.
Note for example that mod works perfectly for an entire array as an input, so you could perform this calculation all in one go, without any loops. We can also use some basic logical indexing to pick the values that we want:
function v = primefact(x)
y = 1:x;
z = mod(x,y);
z = y(z==0);
v = z(isprime(z));
end
Which we can then test to check that it find all of the prime factors:
>> primefact(7)
ans =
7
>> primefact(10)
ans =
2 5
>> primefact(30)
ans =
2 3 5
>> primefact(42)
ans =
2 3 7
>> primefact(43)
ans =
43
Note that this code excludes one from the output.
2 个评论
The code z==0 creates a logical array, and the code y(z==0) uses this logical array as indices into y.
The code z(isprime(z)) is also logical indexing, using isprime to generate the logical array.
更多回答（1 个）
You can replace
b = i;
with
b = [b i];
to create an array. You will get a warning about it resizing in a loop, but in this case it isn't easy to presize it and unless you are doing it on large numbers and the time taken is unacceptable it isn't worth worrying about. Even if the time taken is excessive it may not be due to the resizing of the array anyway.
You will also likely have to change your penultimate line to
b = isprime(b) .* b;
to work for a vector using point-wise multiplication (note the extra '.')
3 个评论
Harel Harel Shattenstein
2015-4-2
编辑：Harel Harel Shattenstein
2015-4-2
Michael Haderlein
2015-4-2
While preallocation is not easy in this case (as Adam mentioned), you at least need to define the variable. Just add before starting the loop
b=[];
Adam
2015-4-2
Ah yes sorry, I forgot that. It's what comes of answering off the top of my head rather than checking it in Matlab first!
类别
在 帮助中心 和 File Exchange 中查找有关 Loops and Conditional Statements 的更多信息
产品
Community Treasure Hunt
Find the treasures in MATLAB Central and discover how the community can help you!
Start Hunting!
Translated by 
