Generate mlint warning when variable is not unused

Question

tommsch 2024-8-30

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/2148979-generate-mlint-warning-when-variable-is-not-unused

评论： tommsch 2024-9-1

mlint gives a warning when a variable is unsed. E.g. in the following code, mlint gives a warning in line (1)

a = 2;  % (1) - here mlint gives a warning (which I know why, and which I do not care about)
a = 3;  % (2)

Is it possible to generate a warning when a variable name is not used. More exactly, I would like to have the following behaviour:

a = 2;  % (3) - I want no warning here, because the variable name is used again in line (4) and/or line (5)
a = 3;  % (4) 
func( a );  % (5)

a = 2;  % (6) - I want a warning here, because the variable name is not used again later on in all paths
if( some_condition );
    a = 3;
end

5 个评论
显示 3更早的评论隐藏 3更早的评论

Walter Roberson 2024-8-30

在 MATLAB Online 中打开

a = 1;
fid = fopen('test.txt', 'w');
if fid > 0
    fprintf(fid, '%d\n', a);
    fclose(fid);
end

and in this case you would want a = 1 to be flagged because the fopen might fail so the fprintf() might not be called?

tommsch 2024-8-30

在 MATLAB Online 中打开

Yes. But I am already satisfied when it works not across function call boundaries, i.e. no difference in behaviour for the variables a and b here. (Since mlint quite surely does not analyse the called functions for its warning, I doubt this would be possible at all).

So, if I inline all the functions from your example, the behaviour should be:

a = 1;  % warning, because it is not used anymore
b = 2;  % no warning, because it is used later
c = 3;  % warning, because it is only conditionally used later
b = b
if rand() > 0.5;
    c;
end;

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Steven Lord 2024-8-30

1
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/2148979-generate-mlint-warning-when-variable-is-not-unused#answer_1507934

在 MATLAB Online 中打开

Is it possible to generate a warning when a variable is not used. More exactly, I would like to have the following behaviour:

a = 2;  % (3) - I want no warning here, because the variable is used again in line (4) and/or line (5)
a = 3;  % (4) 
func( a );  % (5)

It is possible to suppress the Code Analyzer warning on the line labeled 3 as Jatin suggested. But I'd like you to clarify what you mean by "used" in your comment.

The variable name a is assigned to on the lines labeled 3 and 4 and referenced on the line labeled 5. But the value that you set on the line labeled 3 is not used. That's the whole point of the message.

Suppose that instead of assigning the value 2 to a on that line you assigned the result of a computation that took 5 minutes to a on that line. You then turn around and throw that value that MATLAB spent 5 minutes working on in the trash and stick the value 3 in its place. That's potentially a waste of 5 minutes, and that's why Code Analyzer warns you on the line labeled 4. Code Analyzer is basically asking you "Did you really mean to throw away that work I did? Or did you perhaps mistype the variable name on one of the lines?"

In this case, 2 doesn't take any time to compute. But it's the principle: the fact that you assigned data to a variable name then immediately discarded it suggests that you may not be doing what you intended.

7 个评论
显示 5更早的评论隐藏 5更早的评论

Steven Lord 2024-8-30

在 MATLAB Online 中打开

So let's take a sample small function.

function y = myfun(x)
a = 2;  % (6) - I want a warning here, because the variable name is not used again later on in all paths
if( x > 3 )
    a = 3;
end
y = 1;

When I write this in MATLAB Editor, both the first and second references to a are flagged as potentially unused. This is correct. The first reference to a is indeed unused, as whether or not x is greater than 3 there's no usage of the variable a later in the code. The second reference is also unused, as there's still no usage of the variable a later in the code.

With a slight modification to the function:

function a = myfun2(x)
a = 2;  % (6) - I want a warning here, because the variable name is not used again later on in all paths
if( x > 3 )
    a = 3;
end
y = 1;

Now neither reference to a is flagged as potentially unused. This too is correct IMO. The variable named a is used later on in the code, as the output argument from myfun2. Now is it possible that the function will not return a with the value of 2 when called, depending on the value of the input? Yes. Can Code Analyzer's static analysis of the code tell that? No. That is a run-time decision.

So if there were a Code Analyzer message on that first use of a, it would almost have to be a very soft warning. "The variable used on this line may or may not be used depending on the specific value of the input argument." or something like that. There likely would need to be enough caveats for realistic cases and enough false positives that I'm not sure the message would be useful.

But let me take a step back. We've been talking about analyzing the code as though it would be run in MATLAB. Are you hoping to use this type of Code Analyzer message to identify potential problems for a code generation workflow? MATLAB Coder is stricter about certain language constructs / patterns, so it might make sense to have a "MATLAB for Code Generation" Code Analyzer message that flags this pattern if that's your use case. If it isn't, can you say more about what action you would consider taking if that Code Analyzer message appears for a particular line of code?

tommsch 2024-8-30

在 MATLAB Online 中打开

Thanks for the long answer, from which I deduced that my original goal is not even of "academic value" to me: I already knew before asking that question, that I actually should solve the problem I have differently. But I thought, maybe will I learn some tricks about Matlab if I do it that way.

Now my answer to you:

My usecase which I had in mind is the following:

I have a function which needs to compute a value xx and return it. How to compute xx depends on a lot of conditions. If I have a programming error, and xx does not get computed, the function shall still not throw an exception, because my whole application should be very failure tolerant. So I write it like this:

function [ xx ] = func() 
    xx = 1;  % fallback value, if something goes wrong so that no exception is thrown
    if( condition1 )
        xx = 2;
        % very complicated if things continue
        xx = 3;
        % very complicated if things continue
    elseif( condition2 )
        xx = 4;
        if( condition4 )
            xx = 5;
        elseif( condition3 )
            % very complicated if things continue
            xx = 6;
            % very complicated if things continue
            xx = 7;
            % very complicated if things continue
            % very complicated if things continue
            % very complicated if things continue
        end
    end
    
end

So I had the stupid idea, maybe I can get the matlab linter warn me whenever xx does not get accessed again in at least one branch. But this is not possible, because I need xx as the return value, so xx is always touched again. And thus, my goal is not feasible.

What is more, if I do not define xx at the beginning, then matlab will most likely warn me, that xx may be undefined if a certain branch is taken - which is exactly what I wanted to acchieve.

Thanks again.

Steven Lord 2024-8-30

在 MATLAB Online 中打开

What is more, if I do not define xx at the beginning, then matlab will most likely warn me, that xx may be undefined if a certain branch is taken - which is exactly what I wanted to acchieve.

It won't warn you. That's a hard error as long as you're calling the function with enough output arguments that MATLAB needs to know the value of that variable that doesn't exist to return that value to the caller. [If it doesn't need to know that output, because it's not returning that value to its caller, it's neither an error nor a warning. See the third example below.]

myfun(2)
Assigned the value 2 to the variable z.
End of call to myfun with 0 outputs.
ans = 2
y = myfun(2)
Assigned the value 2 to the variable z.
End of call to myfun with 1 outputs.
y = 2
myfun(1)
End of call to myfun with 0 outputs.
y = myfun(1)
End of call to myfun with 1 outputs.
Output argument "z" (and possibly others) not assigned a value in the execution with "solution>myfun" function.
function z = myfun(x)
if x > 1
    z = 2;
    fprintf("Assigned the value 2 to the variable z.\n")
end
fprintf("End of call to myfun with %d outputs.\n", nargout)
end

That being said, I usually assign a value that can't be valid for that variable (NaN often works for numeric data, and more generally I'd use missing for things like string arrays.)

Walter Roberson 2024-8-30

编辑：Walter Roberson 2024-8-30

在 MATLAB Online 中打开

If you happen to be working with single or double,

function [ xx ] = func() 
    xx = nan;  % fallback value, if something goes wrong so that no exception is thrown
    if( condition1 )
        xx = 2;
        % very complicated if things continue
        xx = 3;
        % very complicated if things continue
    elseif( condition2 )
        xx = 4;
        if( condition4 )
            xx = 5;
        elseif( condition3 )
            % very complicated if things continue
            xx = 6;
            % very complicated if things continue
            xx = 7;
            % very complicated if things continue
            % very complicated if things continue
            % very complicated if things continue
        end
    end
    if isnan(xx)
        fprintf("Failed to assign to xx\n");
    end
end

This is a dynamic warning rather than a static warning, so it will not be triggered until the first time you happen to miss an assignment.

tommsch 2024-9-1

Thanks for this nice idea.

请先登录，再进行评论。

Answer 2

Jatin 2024-8-30

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/2148979-generate-mlint-warning-when-variable-is-not-unused#answer_1507804

在 MATLAB Online 中打开

Hi @tommsch,

The warning message about “Value assigned to variable might be unused” at line 3 in your example is because “mlint” works by finding variables that are defined but not used before being overwritten or the script ends.

In MATLAB “mlint” does not provide a way to customize warnings as you describe, but you can suppress warning messages in MATLAB scripts using few ways described below:

1. You can add “%#ok<NASGU>” at the line with warning to suppress “Value assigned to variable might be unused.” warning message, see example below:

function a = mlintcheck() 
    c = 2; %#ok<NASGU> 
    b = 5; 
    if(b > 1) 
        c = 1; 
    end 
end

2. Using User Interface: Right click on the underline of warning message and select: Suppress Message >> On This Line.

In the provided example, line 6 assigns a value to the variable “a”, but it does not use “a” afterward, which should typically trigger a warning about the variable being unused. However, if the variable “a” were to be used as a return value from a function or passed to another function later, the script might not generate this warning.

Note: MATLAB recommends using “checkcode” in place of “mlint” which gives better integration with MATLAB’s Code Analyzer.

Kindly refer to the documentation below to know more about “mlint” and “Adjust Code Analyzer Message Indicators and Messages”:

https://www.mathworks.com/help/matlab/ref/mlint.html

https://www.mathworks.com/help/matlab/matlab_prog/check-code-for-errors-and-warnings.html#mw_98896516-0bde-41cb-a091-932dd2ea7580

2 个评论
显示无隐藏无

tommsch 2024-8-30

Dear Jatin, please understand the question before you post an answer.

Jatin 2024-8-30

Dear tommsch, I attempted to clarify your questions based on the comments you provided in the code. I recommend framing your questions in more detail for better understanding.

请先登录，再进行评论。