loop over nested functions overwrites variables

Question

Julia 2015-5-11

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/216118-loop-over-nested-functions-overwrites-variables

评论： Julia 2015-5-13

I have written a routine for image processing and want to get the same output for a stack of pictures in the format (:,:,i) with i being the number of the picture (e.g. picture number 30 to 35). However, the output will only have information for the final i(:,:,35) and (:,:,30) to (:,:,34) will be empty, that is they have been overwritten. I tried a smaller loop to get the idea

zMin=30; zMax=35;
while zMin <= zMax
       for i = zMin
          a(1,1,i)=zMin
          zMin=zMin+1;
       end;
end;

and here it works perfectly fine. However, in my code consisting of nested functions, it doesn't, so I assume it has something to do with the format of the code:

function [firstScanRaw, mask, maskedImage, Ipores, Iskeleton, PropsLCCP, PropsLCCS, PoresBackbone, SkeletonBackbone, Porosity, Skeleton, nPixelROI, SkeletonObjects, PoreObjects,  EulerRealisationsSkeleton, EulerRealisationsPores,PoreWidthRealisations, SkelWidthRealisations ] = porous_main(sampleName, zMin, zMax, display);
[firstScanRaw] = porous_load_input (sampleName,zMin);
[mask, maskedImage] = porous_polygon (firstScanRaw, display, sampleName);
   while (zMin <= zMax)
     for i = zMin;
[firstScanRaw] = porous_load_input (sampleName,zMin);
[mask, maskedImage] = porous_polygon_choosen (firstScanRaw, display, sampleName, mask,i);
[Ipores, Iskeleton] = porous_binarisation (maskedImage, display,i);
[PropsLCCP, PropsLCCS] = porous_elements(Ipores, Iskeleton, display, i);
[PoresBackbone, SkeletonBackbone, Porosity, Skeleton, nPixelROI, PoreDist, SkelDist] = porous_sizes (Iskeleton, Ipores, display, mask, maskedImage,i);
[Porosity, Skeleton, SkeletonObjects, PoreObjects, EulerRealisationsSkeleton, EulerRealisationsPores, PoreWidthRealisations, SkelWidthRealisations ] = porous_output(Porosity, Skeleton, PoreDist, SkelDist,PoresBackbone, SkeletonBackbone, nPixelROI, sampleName, PropsLCCP, PropsLCCS,i);
      zMin=zMin+1;
      end;
   end;
end

3 个评论
显示 1更早的评论隐藏 1更早的评论

Stephen23 2015-5-11

编辑：Stephen23 2015-5-11

在 MATLAB Online 中打开

Your function currently has eighteen (18) outputs... and this is clearly difficult to keep track of. As an alternative you might like to consider using a structure, which allows you to do this:

function out = temp(x)
out.data = x;
out.sqrt = sqrt(x);
end

and then we can call the function and get all of the output values in just one variable:

>> X = temp(4)
X = 
  data: 4
  sqrt: 2

This has many advantages over trying to pass lots of output variables! You can also use the same method for passing input variables :)

Julia 2015-5-11

I see the advantage of using structures. The question is, why does my current output get overwritten?

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Stephen23 2015-5-11

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/216118-loop-over-nested-functions-overwrites-variables#answer_178649

编辑：Stephen23 2015-5-11

在 MATLAB Online 中打开

Solution

Those loops are very confused. Neither the while nor the for loop is being used effectively.

The for loop does absolutely nothing at all: you provide it with exactly one scalar value zMin, and so it "loops" over just one value... but there is no looping happening with just one value!
Using a while loop is not the best choice, as you already know precisely the start and end values for the loop. This is exactly what for loops are for.

Both of these could be replaced by one simple for loop:

zMin=30;
zMax=35;
for k = zMin:zMax
    a(1,1,k) = k;
end

Bonus Extension

Or perhaps an even better solution (this depends on what you are doing with that matrix) is to not to use the values 30 to 35 directly as indices (and so fill up the rest of the matrix with useless zeros), but instead to use independent indices to locate the values:

zMin=30;
zMax=35;
vec = zMin:zMax;
for k = numel(vec):-1:1
    a(1,1,k) = vec(k);
end

which we can view in the command window:

>> a
a(:,:,1) =
    30
a(:,:,2) =
    31
a(:,:,3) =
    32
a(:,:,4) =
    33
a(:,:,5) =
    34
a(:,:,6) =
    35

This is a much smaller matrix, and it contains only actual data, as opposed to the many useless zeros in your original matrix.

5 个评论
显示 3更早的评论隐藏 3更早的评论

Stephen23 2015-5-11

编辑：Stephen23 2015-5-11

在 MATLAB Online 中打开

Please upload your exact Mfile using the paperclip button, note that you have to click both the Choose file and Attach file buttons. I cannot read minds, and you will need to provide your exact code if you want a diagnosis of this problem.

That style of indexing should work fine:

function [out,F,E] = temp(n,x)
for k = n:-1:1
    out(:,:,k) = x^k + [0,1;10,100];
    [F(k),E(k)] = log2(out(1,1,k));
end

and tested:

>> [A,F,E] = temp(5,2)
A(:,:,1) =
     2     3
    12   102
A(:,:,2) =
     4     5
    14   104
A(:,:,3) =
     8     9
    18   108
A(:,:,4) =
    16    17
    26   116
A(:,:,5) =
    32    33
    42   132
F =
          0.5          0.5          0.5          0.5          0.5
E =
     2     3     4     5     6