faster "log10" command

6 次查看(过去 30 天)
Ricky
Ricky 2011-12-8
Hi all, Is anyone know how to use the "log10" more wisely? currently, I convert from dB to decimal using log10 but it seems to slow down the execution process. Any help would be appreciated!
Ta
[EDITED, 09-12-2011 08:13 UTC, Jan Simon] Code copied from Answer section:
Sorry guys for the late reply, and thanks for the comment. Anyway, my code look like this:
for trial = 1:1000
for a = 1:N
for b=1:N
interfere(b,a) = dBtodec(Pr) * power(dstsr(b,a), -(dBtodec(gamma))))) * ...
Li(b) * Ri(b);
end
%
sinrSUr(a) = dBtodec(Pr) * power(ds(a), -(dBtodec(gamma))))) * ...
LSUr(a) * RSUr(a)) / (dBtodec(No) + sum(interfere(:,a)));
snr(a) = (dBtodec(Pr)*(power(ds(a), (-(dBtodec(gamma))))) * ...
LSUr(a) * RSUr(a)) / (dBtodec(No));
end
end
where dBtodec is a function which is:
function [decimal] = dBtodec(x)
%converting dB to decimal
decimal = 10*log10(x);
end
hope that make sense
  6 个评论
Ricky
Ricky 2011-12-11
sorry i missed out 10 in the code, suppose to be log1o instead of just log. my bad.
Jan
Jan 2011-12-12
@Rak: You can simply edit your question to fix this.

请先登录,再进行评论。

采纳的回答

Jan
Jan 2011-12-9
Calculating -(dBtodec(gamma)) and the other constants repeatedly wastes time. Better do it once and store the value in a temporary variable. All calculations can be performed without loops. E.g.:
snr = dBtodec(Pr) .* power(ds, -dBtodec(gamma)) .* LSUr .* RSUr ./ dBtodec(No);
  2 个评论
Ricky
Ricky 2011-12-11
how would i do that with 2D array?
Jan
Jan 2011-12-12
If all arrays have the same size ".*" multiplies them elementwise. If some are vectors and each element should be multiplied with all elements of a subvector fo the 2D-array, use BSXFUN, which "inflates" the vector "virtually":
x = rand(3, 3); b = rand(1, 3);
y = bsxfun(@times, x, b); % or: y = x .* b(ones(1,3), :)

请先登录,再进行评论。

更多回答(4 个)

Daniel Shub
Daniel Shub 2011-12-8
I am guessing you are not preallocating ...
Does you code look something like:
x = randn(1e7,1);
for ii = 1:length(x)
y(ii) = log10(x(ii));
end
You could replace it with
y = log10(x);
  4 个评论
Jan
Jan 2011-12-8
Then I guess, that we will get a speedup of >55% if we apply our experiences on Rak's code. But even then this will *not* be an advantage: Currently Rak has waited 16 hours for the answer! It will be hard to recover this delay even with the fastest code...
Jan
Jan 2011-12-9
Damn English. Sometimes I'm too confused. While "I guess" is nonsense here, I meant "I bet". And if I had written this, I'd won. What a pitty.

请先登录,再进行评论。


Daniel Shub
Daniel Shub 2011-12-9
You may want to look at
doc db2mag
doc mag2db
doc pow2db
doc db2pow
they are not going to speed up your code, but they do the transformations in the correct direction and use the correct log base and scale factors ...
  1 个评论
Jan
Jan 2011-12-9
See: http://en.wikipedia.org/wiki/Anti-pattern , Do not re-invent the square wheel. +1

请先登录,再进行评论。


Sean de Wolski
Sean de Wolski 2011-12-8
On my system:
A = magic(10000); %Don't do this!
tic,log10(A);toc
Elapsed time is 1.388229 seconds.
1.39 seconds to calculate the log10 of 10000^2 elements seems pretty good, so you probably have something else slowing you down. How much memory are you using?
b = whos;
sum(b(:).bytes)
If you're using more memory than you have RAM available that's quite possibly your issue.

Ricky
Ricky 2011-12-11
Thx people, I manage to speed up my code now, thanks to you all esp. Jan
  2 个评论
Ricky
Ricky 2011-12-12
and fixed everything else
Daniel Shub
Daniel Shub 2011-12-12
the best way to thank people is to accept the best answer and vote for the other answers that helped you. This lets future people with similar questions and problems learn what you learned.

请先登录,再进行评论。

类别

Help CenterFile Exchange 中查找有关 Logical 的更多信息

标签

产品

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by