Can this silly accumarray for-loop be removed by a vectorization?

2015 8 17
3 个回答
回答已采纳
更新时间：2015 8 18
5 次查看（30 天）

2 个投票

I have a matrix A where some of the values in column 1 are duplicates. Where a duplicate exists in column 1 (representing a timestamp) I want to replace the corresponding values in the other columns by a mean value of the duplicates.
Right now Im doing it by identifying the unique values and then loop through the columns one by one via a temporary variable since accumarray only accepts one column at a time:
[UA,~,idx] = unique(A(:,1)); % Finds duplicates in the first column of matrix A
for i = 28:-1:2
Temp = [UA,accumarray(idx,A(:,i),[],@mean)]; % Replaces duplicates with the mean of the duplicate values in column i
B(:,i) = Temp(:,2); % Transfers the results and builds the final matrix B containing the same as A but with no duplicates
end
It is doing what I want but it is really slow, is there any simple way of rewriting it so I don’t have to deal with the for-loop?

请先登录，再回答此问题。

 采纳的回答

Sean de Wolski
Sean de Wolski 2015-8-18
编辑：Sean de Wolski 2015-8-18

1 个投票

A = randi(32280,28);
[UA,~,idx] = unique(A(:,1));
[X,Y] = ndgrid(idx, 2:size(A,2));
newcolumns = accumarray([X(:), Y(:)], reshape(A(:,2:end),[],1), [], @mean);
The ndgrid needs to start in the second column and only extract the 2nd through end columns of A for vals.

1 个评论
显示 -1更早的评论 隐藏 -1更早的评论

Peta
Peta 2015-8-18
Thank you that worked as it should. But sadly it turned out to be slower compared to the original for-loop method.

请先登录，再进行评论。

更多回答（2 个）

Kelly Kearney
Kelly Kearney 2015-8-18

1 个投票

I'm not sure if it will be faster, but you may try my aggregate function. It only calls accumarray once under the hood, though, using indices to make the application to multiple columns a little more efficient.
[~, B] = aggregate(A(:,1), A, @(x) mean(x,1));
B = cat(1, B{:});
Walter Roberson
Walter Roberson 2015-8-17

0 个投票

colidx = repmat(1:size(A,2), size(A,1), 1);
newcolumns = accumarray([idx, colidx(:)], reshape(A(2:end,:),[],1), [], @mean);
output = [UA, newcolumns];

3 个评论
显示 1更早的评论 隐藏 1更早的评论

Peta
Peta 2015-8-17
That’s not working for me, I’m getting ” Error using horzcat Dimensions of matrices being concatenated are not consistent.”. Because my A is 32280x28, which makes my colidx(:) size 903840x1 while idx is just 32280x1.
So I think the error is in [idx, colidx(:)]
Walter Roberson
Walter Roberson 2015-8-17
Hmmm... Try
[X,Y] = ndgrid(idx, 1:size(A,2));
newcolumns = accumarray([X(:), Y(:)], reshape(A(2:end,:),[],1), [], @mean);
Peta
Peta 2015-8-18
编辑：Peta 2015-8-18
No, it’s still not quite right I think.
I’m getting an error saying that VAL must have one element for each row in SUBS. Which is because [X(:), Y(:)] which corresponds to SUBS has a slightly different dimension than reshape(A(2:end,:),[],1) which would be VAL.
A = randi(32280,28);
[UA,~,idx] = unique(A(:,1));
[X,Y] = ndgrid(idx, 1:size(A,2));
newcolumns = accumarray([X(:), Y(:)], reshape(A(2:end,:),[],1), [], @mean);
Error using accumarray
Second input VAL must be a vector with one element for each row in SUBS, or a scalar.

请先登录，再进行评论。

类别

在 帮助中心 和 File Exchange 中查找有关 Loops and Conditional Statements 的更多信息

产品

标签

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by