How to allocate the content of a M1 vector to a TN matrix (M<T*N) ? problem with cell format

Question

James Grayout 2016-4-21

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/280175-how-to-allocate-the-content-of-a-m-1-vector-to-a-t-n-matrix-m-t-n-problem-with-cell-format

评论： James Grayout 2016-4-22

Dear all

I am newcomer to matlab and have a question that, I believe, should be easy to solve. Yet, I have lost way too many hours on this particular detail and find myself unable to advance. I hope someone can point out the problem. Maybe the function is poorly coded to begin with. Anyways, thanks in advance!

I have a set of unbalanced monthly data for various firms.

I want to create a matrix y: dim(y) = T * N, where T is number of periods and N is number of firms

My idea is to create a function - ymatrix - that retrieves the value of interest at time t for firm n and places it in position (t,n) in the matrix y.

With this in mind, I wrote the function below:

 function y = ymatrix(intersection,date,id,var)
 % intersection is an argument that allows me to determine the number of columns of y. % id is the the identification
 % number of the firm - in cell format % var is that variable of interest
 [R C] = size(intersection);
 T = [2007 - 1964 + 1]*12 + 12;
 clear C
 y = NaN(T,R);
 clear T
 sortDate = sort(date,'ascend'); % I do no sort IDs as they are already sorted in the dataset
 T = length(date);
 N = length(id);
 past = cell(T,1);
 for t = 1 : T
    for n = 1 : N
        if sum(ismember(past,id{n})) == 0               
       % This is where the problem seems to lie. Since I want to have each column of y as a firm
       % and since in the dataset a given id appears many times, I must apply the current loop only for firms to which
       % I haven't applied it before. Otherwise, I will have several repeated columns.
       % Hence, at the end of each loop, I want to add the id of the firm I am currently looping through to a 
       % local variable - "past" - that I can then use - in the next loop - to decide whether to skip that particular
       % loop. The problem is that id is in cell format. Either I pre-allocate memory to past in cell format and 
       % use past{n,1} = id{n,1}, in which case, in the next loop, I receive an error in sum(ismember(past,id{n})) ==
       % 0 that reads :
       %"Input must be cell arrays of strings"; or I do not preallocate it to be a cell and allocate it as, 
       %for instance,past = NaN(10,1), and I receive an error in past{n,1} = cusip{n,1} that 
       %reads: "Cell contents assignment to a non-cell array object."
            a = ismember(date,sortDate(t));
            b = ismember(id,id{n});                     
            a = int8(a);
            b = int8(b);
            d = find(a == 1);
            e = find(b == 1);
            index = intersect(d,e);         % Note that the intersection must either be a number of empty
            past{n,1} = id{n,1};
                if index == zeros(0,1)      % This is to account for the possibility that the intersection is empty,
                                            % in which case I simply skip the current loop
                else
                    y(t,n) = var(index,1); 
                end
        else
        end
    end
 end
 end

4 个评论
显示 2更早的评论隐藏 2更早的评论

James Grayout 2016-4-21

在 MATLAB Online 中打开

inputs:

intersection - 10281*1 cell

date - 1431697*1 double

id - 1431697*1 cell

var - 1431697*1 double

 NaN
 NaN
 -0,509591836734694
 -0,590000000000000

I want the output to be a matrix such that:

1) each row is a date

2) each column is a firm

Hence y(1,1) = the value of the variable for the "1st" firm in the "1st time period".

Hope this helps, Guillaume. Let me know if you need further info .

James Grayout 2016-4-21

another detail about the input date:

I have monthly data for 1964 till 2007 plus data from July to December 1963 and date from January to June 2008.

Hence, the output matrix should be a (12 + 12*(2007-1964+1))*10281 matrix, where 10281 is the number of firms. Some of the entries are supposed to be NaN as I do not have data for all firms for all years.

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Guillaume 2016-4-21

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/280175-how-to-allocate-the-content-of-a-m-1-vector-to-a-t-n-matrix-m-t-n-problem-with-cell-format#answer_218834

编辑：Guillaume 2016-4-21

在 MATLAB Online 中打开

If I understood correctly, this should work:

[udate, ~, drow] = unique(date); %udate could be replaced by ~ if you don't want a table
[uid, ~, idrow] = unique(id);    %uid could be replaced by ~ if you don't want a table
y = nan(max(drow), max(idrow));
y(sub2ind(size(y), drow, idrow)) = var;

You can prettify the output with:

t = array2table(y, VariableNames, uid, RowNames, cellstr(num2str(udate)))

Note that neither date or id need to be sorted since unique does the sorting anyway.

5 个评论
显示 3更早的评论隐藏 3更早的评论

Guillaume 2016-4-22

I'm afraid I've only learned matlab from its help file but I had a lot of experience programming in other languages beforehand. I've actually never read any book about matlab.

Solving problems (the not too trivial ones) on Cody and seeing other solvers' approach may be a good way of acquiring experience with matlab functions.

James Grayout 2016-4-22

Thanks!

请先登录，再进行评论。

Answer 2

Renato Agurto 2016-4-21

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/280175-how-to-allocate-the-content-of-a-m-1-vector-to-a-t-n-matrix-m-t-n-problem-with-cell-format#answer_218819

在 MATLAB Online 中打开

If you preallocate past:

past = NaN(10,1);

then you should use

past(n,1) = id{n,1};

instead of

past{n,1} = id{n,1};

3 个评论
显示 1更早的评论隐藏 1更早的评论

James Grayout 2016-4-21

ps: id{1,1} is only numbers by chance. quite often id's are like 652AA145. thus the need for cells

James Grayout 2016-4-21

在 MATLAB Online 中打开

Hi again. So the loop is currently working when I write ymatrix as shown below. I am not sure whether the result will be correct though, as the loop will take a while.

 function output = ymatrix(intersection,date,id,var)                         
 R = numel(intersection);
 T = [2007 - 1964 + 1]*12 + 12;
 Y = NaN(T,R);
 sortDate = sort(date,'ascend');                                             
 T = length(date);
 N = length(id);
 past = NaN(N,8);
 for t = 1 : T
    for n = 1 : N
        if sum(sum(ismember(past,id{n}))) ~= 8
            a = ismember(date,sortDate(t));
            b = ismember(id,id(n));                     
            d = find(a == 1);
            e = find(b == 1);
            index = intersect(d,e);                                         
            past(n,:) = string(id{n,1});
                if isempty(index)
                else
                    Y(t,n) = var(index,1); 
                end
        else
        end
    end
 end
 output = Y(t,n);
 end

Yet, in each loop, I get the message

 In ymatrix at 36
 Warning: string is obsolete and will be discontinued.
         Use char instead

1) However, char does not work in this context... Am I making any mistake here?

2) Also, is there any way of not having the warning appearing in each loop?

3) Assuming that the code produces the desired result, would there be a more efficient/faster way of doing the same thing?

请先登录，再进行评论。

How to allocate the content of a M1 vector to a TN matrix (M<T*N) ? problem with cell format

4 个评论
显示 2更早的评论隐藏 2更早的评论

采纳的回答

5 个评论
显示 3更早的评论隐藏 3更早的评论

更多回答（1 个）

3 个评论
显示 1更早的评论隐藏 1更早的评论

另请参阅

类别

标签

Community Treasure Hunt

How to allocate the content of a M*1 vector to a T*N matrix (M<T*N) ? problem with cell format

4 个评论 显示 2更早的评论隐藏 2更早的评论

采纳的回答

5 个评论 显示 3更早的评论隐藏 3更早的评论

更多回答（1 个）

3 个评论 显示 1更早的评论隐藏 1更早的评论

另请参阅

类别

标签

Community Treasure Hunt

How to allocate the content of a M1 vector to a TN matrix (M<T*N) ? problem with cell format

4 个评论
显示 2更早的评论隐藏 2更早的评论

5 个评论
显示 3更早的评论隐藏 3更早的评论

3 个评论
显示 1更早的评论隐藏 1更早的评论