Changing the declaration of a function?

1 次查看（过去 30 天）

显示更早的评论

amine&& 2016-7-8

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/294271-changing-the-declaration-of-a-function

评论： Walter Roberson 2016-7-11

采纳的回答： Walter Roberson

在 MATLAB Online 中打开

I have a following function that begins with:

function X=mFunction(alpha,beta)
%%load the dataset
filename = 'Bo_1.xlsx';
y = xlsread(filename);
yS=y(1:288);

I want to minimize it. But without load data every time..

How I should proceed?

Thanks!

5 个评论
显示 3更早的评论隐藏 3更早的评论

Image Analyst 2016-7-9

You said you wanted to minimize it, so I just threw out everything that wasn't absolutely needed for the function to run. You assign a filename and read in a workbook but don't actually return it to your calling function, so I got rid of that unneeded part. From your comment later to Walter it sounds like you don't even know what alpha and beta are, so you might not need those either, and the function could be simplified even more - just don't have any input arguments. Now you'll have a function that does absolutely nothing - about as minimal as you can get.

amine&& 2016-7-9

Ok Image Analyst, it is very interesting what you say I'll take it in concideration. Thanks!

请先登录，再进行评论。

请先登录，再回答此问题。

采纳的回答

Walter Roberson 2016-7-8

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/294271-changing-the-declaration-of-a-function#answer_228082

在 MATLAB Online 中打开

function run_my_plot
    alpha = ....
    beta = ....
    filename = 'Bo_1.xlsx';
    y = xlsread(filename);
    yS=y(1:288);
    X = arrayfun(alpha, beta, yS);
    surf(alpha, beta, X, 'edgecolor', 'none');
function X = mFunction(alpha, beta, yS)
  .... code with no load() goes here

10 个评论
显示 8更早的评论隐藏 8更早的评论

Image Analyst 2016-7-9

在 MATLAB Online 中打开

There's no possible way for us to know if this (alpha and beta) is good for you or not. All you said was that you're starting with this:

function X=mFunction(alpha,beta)
%%load the dataset
filename = 'Bo_1.xlsx';
y = xlsread(filename);
yS=y(1:288);

and that you don't want to load data every time. We're not even sure if there is anything later down in the function that you did not include. For example, you compute yS but never use it in the code you've shown. Why not? You also pass in alpha and beta but never show them being used, so how are we supposed to know what they might be or be used for? You said you don't want to load the data in every time, so maybe that means you just read in y outside that function (in your calling routine) and then pass y into mFunction() from the calling routine via mFunction's input argument list

function X=mFunction(y, alpha, beta)
yS=y(1:288);

But again, yS is not returned or used ever, so who knows what this function is supposed to do? Moreover, you (try to) return X but you never set X in the function, so that will throw an error.

Please read this link so we can help you better.