I nee to change this str2double code while keeping the same output for my collatz function.

Question

Kevin Smith 2017-9-25

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/358172-i-nee-to-change-this-str2double-code-while-keeping-the-same-output-for-my-collatz-function

评论： Stephen23 2017-9-25

The following is the script to my function:

function [steps,maxnum]=collatz(num)
str=input('Enter an integer greater than 1:','s');
num=str2double(str);
cnt=0;
maxnum=num;
while num>1
    cnt=cnt+1;
    if mod(num,2);
        num=num*3+1;
    else
        num=num/2;
    end
    if num>maxnum; maxnum=num;
    end
end
s=cnt
maxnum

I was told that I cannot use the str2double(str) function but I cannot figure out how to get the same output any other way. My script is supposed to take a number greater than 1 and apply a while loop by multiplying the integer by 3 then adding 1 if it is odd or dividing it by 2 if it is an even number until the function equals 1, where the loop ends. I need a different method for finding the steps it takes for the loop to end. For example if the user enters "3" the steps would be 3 → 10 → 5 → 16 → 8 → 4 → 2 → 1. I would need the output to be s=7 %meaning it took 7 steps to complete the loop m=16 %representing the maximum number reached during the loop

3 个评论
显示 1更早的评论隐藏 1更早的评论

Stephen23 2017-9-25

@KSSV: there is nothing wrong with the code. The problem is the ill-informed tutor.

Kevin Smith 2017-9-25

编辑：Kevin Smith 2017-9-25

I apologize I didn't even need that code. I wrote it as a script prompting a user for an integer instead of writing a function like I needed. As a script it had to be a string to find the maximum value, but I don't have to have a string to find the max value when it is a function.

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Stephen23 2017-9-25

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/358172-i-nee-to-change-this-str2double-code-while-keeping-the-same-output-for-my-collatz-function#answer_282969

编辑：Stephen23 2017-9-25

在 MATLAB Online 中打开

str = input('Enter an integer greater than 1:','s');
num = sscanf(str,'%i');

Although str2double has the advantage that it returns NaN for incorrect inputs.

Tell your mysterious advisor that using input to return a string is much safer than getting input to evaluate whatever random things the user has given it, and that they should encourage their students to learn good (defensive) programming practices. Using input without returning a string causes it to evaluate the input given to it by the user, which is an awfully insecure, unsafe, and buggy way to write code, and all of the points listed here apply (particularly the insecure part):

https://www.mathworks.com/matlabcentral/answers/304528-tutorial-why-variables-should-not-be-named-dynamically-eval

You might like to read the discussion here too:

https://www.mathworks.com/matlabcentral/answers/357420-how-to-convert-a-numeric-string-into-a-numeric-range#comment_485955

If your mysterious advisor then ill-advisedly insists that you really really need to use input by getting it evaluate whatever that user gives it then of course you will have to follow their instructions... and you will have learned the valuable lesson that people do not always know what they are talking about. You will know better.