Help to vectorise a conditional cumulative sum

2017 11 20
1 个回答
更新时间：2017 11 22
4 次查看（30 天）

0 个投票

If you have any time, I need some help vectorizing! Racking my brains, and I can’t figure out a way!
I have two vectors of length m: L and W. L contains a vector of lengths, and W contains a vector of corresponding widths. I would like to make a third vector, C, which is the cumulative total of the elements of L subject to the corresponding W being less than the current value of W. i.e. if W(j)<W(i) for j<i, then include L(j) in the sum, if not, then exclude it from the sum.
I can easily do this using a for loop:
C(1) = 0;
for i = 2:m
C(i) = sum(L(1:i-1).*(W(1:i-1)<W(i)))
end
however, I cannot think of a way to vectorize this. Can anyone think of a way?
Thanks, Ric

请先登录，再回答此问题。

回答（1 个）

Andrei Bobrov
Andrei Bobrov 2017-11-21

0 个投票

C = sum(tril(W(:) > W(:)',-1).*L(:)',2);

3 个评论
显示 1更早的评论 隐藏 1更早的评论

Ric Porteous
Ric Porteous 2017-11-21
Hi Andrei,
Thanks so much for your reply. This definitely worked. One thing I noticed, though, is that you get no speed benefit when applying the method to vectors that are >10^3. For example:
m = 10000;
L=randi([1 10],1,m);
W=randi([1 10],1,m);
tic
C = zeros(m,1);
C(1) = 0;
for i = 2:m
C(i) = sum(L(1:i-1).*(W(1:i-1)<W(i)));
end
toc1 = toc
tic
C2 = sum(tril(W(:) > W(:)',-1).*L(:)',2);
toc2 = toc
toc1 = 0.41 s
toc2 = 0.81 s
I guess that making a giant 10000x10000 matrix might not be the most computationally efficient thing to do. Any thoughts on this?
Thanks, Ric
Andrei Bobrov
Andrei Bobrov 2017-11-22
编辑：Andrei Bobrov 2017-11-22
In case use largest arrays your variant with use loop effecient than my variant.
Stephen23
Stephen23 2017-11-22
@Ric Porteous: there is no guarantee that vectorized code is more efficient. As you have just found out, when very large intermediate arrays must be created then it is quite possible that a loop is faster.
Do some timing test and decide for yourself. Keep in mind code complexity/comprehensibility and future memory improvements.

请先登录，再进行评论。

类别

在 帮助中心 和 File Exchange 中查找有关 Performance and Memory 的更多信息

标签

评论：

Stephen23
Stephen23
2017-11-22

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by