Remove my for loop using meshgrid?

3 次查看（过去 30 天）

Manne Plok 2018-9-4

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/417405-remove-my-for-loop-using-meshgrid

评论： Walter Roberson 2018-9-5

[rows, ~, ~] = size(file)
for i = 1:rows 
value = min(abs(file(i,:,1) - shadow(:,:,1)).^2);
storage(i,:) = value;
end

How do i avoid the for loop in this scenario?

9 个评论
显示 7更早的评论隐藏 7更早的评论

Walter Roberson 2018-9-5

在 MATLAB Online 中打开

For real values,

min(abs(file(i,:,1) - shadow(:,:,1)).^2)

is the same as

min(abs(file(i,:,1) - shadow(:,:,1))).^2

but the later is more efficient since it only needs to square a single value.

Let's see... 1 x n x 1 minus a x 1 x 1 is an error in R2016a and earlier. In R2016b and later, it will give an a x n result. abs() of that would be a x n. squaring that would be a x n. min() of that would be 1 x n. And that would be acceptable to store into 1 x n in the next row.

To confirm: you want to find the square of the closest distance that exists between each value in file(i,:,1) and all of the values in shadow(:,:,1) ?

Manne Plok 2018-9-5

Yes that is exactly right.

请先登录，再进行评论。

请先登录，再回答此问题。

回答（1 个）

Greg 2018-9-5

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/417405-remove-my-for-loop-using-meshgrid#answer_335489

编辑：Greg 2018-9-5

在 MATLAB Online 中打开

Given the following code, why are file and shadow 3D? Have we left off an outer loop over dim 3?

[rows, ~, ~] = size(file)
%%%I really don't like "i" as loop index
for irow = 1:rows 
  value = min(abs(file(irow,:,1) - shadow(:,:,1)).^2);
  storage(irow,:) = value;
end

To take advantage of any tricks to avoid the loop, you need another dimension in your data. Note, this requires potentially excessive memory for any speedup you might gain. Assuming you want to do the same thing across the third dimension, try:

shadow = permute(shadow,[4,2,3,1]);
%%%Implicit expansion *will do* multiple singleton dimensions
delta = file - shadow; % R2016b+
% delta = bsxfun(@minus,file,shadow); % R2016a-
storage = min(abs(delta),[],4).^2;

If the third dimension is handled differently, you can use:

shadow_temp = permute(shadow(:,:,1),[2,3,1]);
delta = file - shadow_temp; % R2016b+
% delta = bsxfun(@minus,file,shadow_temp); % R2016a-
storage = min(abs(delta),[],3).^2;

I leave you with 2 thoughts:

Other MVPs encourage the use of bsxfun even in R2016b+. I've never benchmarked it but I trust them when they say it is faster. I personally use implicit expansion for readability. I aim for fast enough code that is easier to read and write versus fastest possible code that coworkers may struggle with.
Depending on your data, you may not need both the abs and .^2. Likely, the squaring accomplishes what you want the abs for, so kill the abs and suck the square inside the min call.

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Walter Roberson 2018-9-5

More recent tests are not as clear about the relative speeds of bsxfun and implicit expansion. Implicit expansion might possibly be a hair faster in some cases, but the margin of error in the measurements far exceeded the difference in timings.

请先登录，再进行评论。

请先登录，再回答此问题。