I would not use a large if / elseif / else / end tree. A switch / case / end statement would be a simpler approach that may be of use to you later in your implementation, but there's an even easier technique you can use for this case. Just use indexing to select a random element from a list of careers.
function pfc1_Callback(hObject, eventdata, handles)
collegechoice=questdlg("Go To College?");
if collegechoice == "Yes"
listOfCareers = ["Entertainer"; "Computer Consultant"; "Teacher"; ...
"Athlete"; "Sales Person"; "Police Officer"; ...
"Artist"; "Doctor"; "Accountant"];
career=randi(9);
handles.careerbox1.String = listOfCareers(career);
else
handles.careerbox1.String = "Unemployed";
end
You could add additional careers to the list if you wanted. The numel function will be of use to you if you do.
I modified the code to use string data rather than char data. That way you can avoid the need to work with cell arrays containing char arrays, which can be confusing at times.
