how to speed my code up

Question

0 个投票

Hello everone,

Here, line 4 and 5 is called 5525575680 times and they last 280 and 230 seconds in order. May I speed it up, how can I use it more efficient ?

  function  [utilization] = totalUtilization(myArray, periodNumber, count, LPP)
     duration = 0;
     for i = 1:count
          duration = duration + myArray(periodNumber, i);
     end
     utilization = duration / LPP;
  end

Thanks in advance.

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

cglr 2019-11-16

Because, I still can't get used to ability of MATLAB :) .

You are exactly true and no need to loop for sum or etc. I wrote the function taking into account to your comment:

utilization = sum(myArray(periodNumber,:)) / LPP;

Thank you so much.

请先登录，再进行评论。

请先登录，再回答此问题。

请先登录再关注

Answer 1

Daniel M 2019-11-16

编辑：Daniel M 2019-11-16

在 MATLAB Online 中打开

1 个投票

Why do you need a loop to compute a sum? Just replace the entire function with

utilization = sum(myArray(periodNumber, 1:count)) / LPP;

And if count is equal to the number of columns of myArray, replace "1:count" with just ":" to avoid making an extra temporary index.

If periodNumber happens to be a vector, then include the number 2 as the dimension input into sum.

4 个评论
显示 2更早的评论隐藏 2更早的评论

cglr 2019-11-17

actually table is a regular array with the size (period,telCount). And I can ask the question in a better way as seen below:

x = zeros(period,1);

for i=1:period

x(i,1) = sum(table(i,1:telCount));

end

Here what I want is, sum all column for each row and write result to x array.

Daniel M 2019-11-17

You really enjoy writing loops! But you don't need to. Look up the documentation for the sum function. It shows you how to do just that.

请先登录，再进行评论。

how to speed my code up

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

采纳的回答

4 个评论
显示 2更早的评论隐藏 2更早的评论

更多回答（0 个）

类别

标签

Community Treasure Hunt

how to speed my code up

1 个评论 显示 -1更早的评论 隐藏 -1更早的评论

采纳的回答

4 个评论 显示 2更早的评论 隐藏 2更早的评论

更多回答（0 个）

类别

标签

另请参阅

Community Treasure Hunt

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

4 个评论
显示 2更早的评论隐藏 2更早的评论