How to decrease run time in swap operation ?

Question

cglr 2019-11-23

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/492733-how-to-decrease-run-time-in-swap-operation

回答： Guillaume 2019-11-23

Hi everyone,

I make the swap operation as shown below but it consumes time too much. Could you have any offer for swap operation in 2D array ?

 while (firstPeriod <= totalPeriod && secondPeriod <= totalPeriod)
    temp = myArray(firstPeriod, firstTelegramArray);
    myArray(firstPeriod, firstTelegramArray) = myArray(secondPeriod, secondTelegramArray);
    myArray(secondPeriod, secondTelegramArray) = temp;
    firstPeriod = firstPeriod + rate;
    secondPeriod = secondPeriod + rate;   
end

Thanks in advance.

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Walter Roberson 2019-11-23

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/492733-how-to-decrease-run-time-in-swap-operation#answer_402934

编辑：Walter Roberson 2019-11-23

在 MATLAB Online 中打开

Before loop:

mysz = size(myArray);

In loop:

idx1 = sub2ind(mysz, firstPeriod, firstTelegramArray);
idx2 = sub2array(mysz, secondPeriod, secondTelegramArray);
myArray([idx1 idx2]) = myArray([idx2 idx1]);

This can be made more efficient at the expense of being less clear.

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

Answer 2

Guillaume 2019-11-23

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/492733-how-to-decrease-run-time-in-swap-operation#answer_402935

在 MATLAB Online 中打开

What's the purpose of the while loop since you know beforehand when it ends and thus how many steps it will do?

Assuming that firstTelegramArray and secondTelegramArray are distinct (or that there's no overlap between the periods) your code is equivalent to:

%assuming that firstPeriod is initially StartfirstPeriod (not shown in your code)
%assuming that secondPeriod is initially StartsecondPeriod (not shown in your code)
firstPeriod = StartfirstPeriod:rate:totalPeriod;
secondPeriod = StartsecondPeriod:rate:totalPeriod;
%in case the two vectors have different length crop to the shorter one (same way the while loop behaves
minlength = min(numel(firstPeriod), numel(secondPeriod)); 
firstPeriod = firstPeriod(1:minlength);
secondPeriod = secondPeriod(1:minlength);
%now do all the swaps, this may be faster than using a temporary variable
indicesfirst = sub2ind(size(myArray), firstPeriod, repelem(firstTelegramArray, minlength));
indicessecond = sub2ind(size(myArray), secondPeriod, repelem(secondTelegramArray, minlength));
myarray([firstindices, secondindices]) = myarray([secondindices, firstindices]);