How can i speed up my function?
显示 更早的评论
Hello everybody,
I'm trying to increase the performance of my Matlab function. Input is a table with the same columns as airfoil_update.
The function splits the X-Coordinates of one AeroDataId at the minimum of X/C and does this for every AeroDataId in the table. Airfoil, the input table, will have a size of 131123421x4. But the fourth column "Upper" is empty and should be filled up with a 1, if the coordinate belongs to the upper airfoil and 0, if it belongs to the lower airfoil.
Thank you very much in advance.
function [airfoil_update] = splitAirfoil(airfoil)
%% create table for upper and lower airfoil
airfoil_update=array2table(zeros(0,4),'VariableNames',{'AeroDataId','X_C','CP','Upper'});
%% vector with unique AeroDataIds
DataId_unique=unique(airfoil.AeroDataId);
for i=1:1:size(DataId_unique)
%% temp vector filled with every point of specific AeroDataId
disp(DataId_unique(i,:));
AeroDataId=airfoil(airfoil.AeroDataId==DataId_unique(i,:),:);
%% find the minimum of X/C
[~, min_idx]=min(AeroDataId.X_C);
%% every point with same ID before minimum -> lower_airfoil -> Upper =0
airfoil_new=AeroDataId(1:min_idx,:);
airfoil_new.Upper(:,:)=0;
airfoil_update=[airfoil_update; airfoil_new];
%% every point with same ID after minimum = upper_airfoil -> Upper =1
airfoil_new=AeroDataId(min_idx+1:end,:);
airfoil_new.Upper(:,:)=1;
%% add new rows
airfoil_update=[airfoil_update; airfoil_new];
end
end
4 个评论
Daniel Ribeiro Gonçalves
2020-1-8
Well,
Besides avoid repeated lines, wicht I think you didn't , you can make your vectors and matrixes sparse, sympley like this:
sparse(airfoil_update);
sparse(airfoil_new);
and goes on...
What will do is basically squeeze out all the zeros in the matrixes and vectors
Gerrit
2020-1-8
Daniel Ribeiro Gonçalves
2020-1-9
They wont be deleted.. Its only for the matter of performance.. It will lower your program computacional time
采纳的回答
Philippe Lebel
2020-1-8
编辑：Philippe Lebel
2020-1-8
In order to help you in a significant way, it would be useful to have a sample data set on which we could run the function.
On the top of my head, i'd remove the disp() function call. Printing info to the console takes a significant amount of time for no real benefit.
I would also pre-alocate the size of
airfoil_update
since you know it's maximum size, you can pre alocate it to that size and keep track of the number of elements you put in it then chop the unused space only once at the end of the script.
9 个评论
Gerrit
2020-1-8
Philippe Lebel
2020-1-8
you can attach a file to your question as you would do in a emal
Gerrit
2020-1-8
Philippe Lebel
2020-1-9
编辑：Philippe Lebel
2020-1-9
here is my shot, the bigger part of the computation time was copying the data, so i avoided doing that.
function [airfoil] = splitAirfoil_new(airfoil)
%% vector with unique AeroDataIds
[DataId_unique,ia, ic]=unique(airfoil.AeroDataId);
ia = [ia; size(airfoil.AeroDataId,1)];
min_indexes = [];
nrow = size(airfoil,1);
airfoil.Upper = zeros(nrow, 1);
for i=1:1:size(DataId_unique)
%% find the minimum of X/C
[~, min_idx]=min(airfoil{ia(i):ia(i+1)-1,2});
airfoil.Upper(ia(i)+min_idx:ia(i+1)-1) = 1;
end
end
in the end, since matlab r2011, the automatic growth of arrays is handled pretty well, so there is not a big chunk of processing time to be gained there anyway.
The code you provided yielded and empty airfoil.Upper (Empty matrix: 122859-by-0). I'm not sure why. So watch out because my result is not exctly the same form factor as yours.
clear
airfoil=readtable('MsesData_0-500.csv','ReadVariableNames',1);
tic
airfoil_update_1=splitAirfoil_new(airfoil);
toc
tic
airfoil_update_2=splitAirfoil_init(airfoil);
toc
Elapsed time is 0.151890 seconds.
Elapsed time is 1.499844 seconds.
(i removed the 'disp()' part of your function to compare)
Gerrit
2020-1-9
Philippe Lebel
2020-1-9
could take a look at it, post an other question and comment the link to the new question here
Philippe Lebel
2020-1-9
I just edited my answer, there was a lot of unused code and the second for loop was not needed.
Gerrit
2020-1-9
Gerrit
2020-1-12
更多回答（0 个）
类别
在 帮助中心 和 File Exchange 中查找有关 Airfoil tools 的更多信息
Community Treasure Hunt
Find the treasures in MATLAB Central and discover how the community can help you!
Start Hunting!
Translated by 
