optimizing for loop that is been called often

2020 2 8
1 个回答
回答已采纳
更新时间：2020 2 8
3 次查看（30 天）

0 个投票

can this loop be optimized? It is called 1m times and is the only thing I couldn't optimize yet.
Oper_year=1:1:Lifetime;
[costM,PVcost,YearProd,Elcost]=deal(zeros(size(Oper_year)));
for j=1:1:length(Oper_year)
if j==1
costM(j)=Mcost*PVprice*PVP;
PVcost(j)=PVprice*PVP+Bcost;
YearProd(j)=sum(PMDb)*PVP;
Elcost(j)=Elprice;
Bcost(j)=Bcost;
else
Bcost(j)=Bcost(1)*(1+bank*Oper_year(j-1));
costM(j)=PVprice*(Mcost*(1+Minf)*(Oper_year(j-1))+Mcost)*PVP;
PVcost(j)=(PVprice*PVP)*(1+bank*Oper_year(j-1))+Bcost(j);
YearProd(j)=sum(PMDb)*PVP*((1-PVdeg)*Oper_year(j-1)+1);
end
end
thanks

请先登录，再回答此问题。

 采纳的回答

KSSV
KSSV 2020-2-8

0 个投票

Oper_year=1:1:Lifetime;
[costM,PVcost,YearProd,Elcost]=deal(zeros(size(Oper_year)));
costM(1)=Mcost*PVprice*PVP;
PVcost(1)=PVprice*PVP+Bcost;
YearProd(1)=sum(PMDb)*PVP;
Elcost(1)=Elprice;
Bcost(1)=Bcost;
Bcost(2:end)=Bcost(1)*(1+bank*Oper_year(1:end-1));
costM(2:end)=PVprice*(Mcost*(1+Minf)*(Oper_year(1:end-1))+Mcost)*PVP;
PVcost(2:end)=(PVprice*PVP)*(1+bank*Oper_year(1:end-1))+Bcost(2:end);
YearProd(2:end)=sum(PMDb)*PVP*((1-PVdeg)*Oper_year(1:end-1)+1);

5 个评论
显示 3更早的评论 隐藏 3更早的评论

Asliddin Komilov
Asliddin Komilov 2020-2-8
In an assignment A(:) = B, the number of elements in A and B must be the same.
Error in LCOE_offG (line 103)
Bcost(2:end)=Bcost(1)*(1+bank*Oper_year(1:end-1));
KSSV
KSSV 2020-2-8
This line
Bcost(j)=Bcost;
What is Bcost size? Provide values for other variables.
Asliddin Komilov
Asliddin Komilov 2020-2-8
编辑：Asliddin Komilov 2020-2-8
this loop is inside other loops, and sometimes Bcost=0, otherwise its an array.
KSSV
KSSV 2020-2-8
The error is becasue the variable Bcost has been treated as scalar as well as vector. Rename the scalar Bcost to some other name. I followed like below:
% some random values for demo
Lifetime = 12 ;
Mcost = rand ;
PVprice = rand ;
PVP = rand ;
BCost = rand ;
PMDb = rand ;
Elprice = rand ;
bank = rand ;
Minf = rand ;
PVdeg = rand ;
Oper_year=1:1:Lifetime;
[costM,PVcost,YearProd,Elcost,Bcost]=deal(zeros(size(Oper_year)));
costM(1)=Mcost*PVprice*PVP;
PVcost(1)=PVprice*PVP+BCost;
YearProd(1)=sum(PMDb)*PVP;
Elcost(1)=Elprice;
Bcost(1)=BCost;
Bcost(2:end)=Bcost(1)*(1+bank*Oper_year(1:end-1));
costM(2:end)=PVprice*(Mcost*(1+Minf)*(Oper_year(1:end-1))+Mcost)*PVP;
PVcost(2:end)=(PVprice*PVP)*(1+bank*Oper_year(1:end-1))+Bcost(2:end);
YearProd(2:end)=sum(PMDb)*PVP*((1-PVdeg)*Oper_year(1:end-1)+1);
Asliddin Komilov
Asliddin Komilov 2020-2-8
I got the point, I will see if it will be faster than the existing code. Thanks

请先登录，再进行评论。

更多回答（0 个）

类别

在 帮助中心 和 File Exchange 中查找有关 Loops and Conditional Statements 的更多信息

产品

标签

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by