Error in unziping files loop

Question

Oktavian Jason 2020-2-19

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/506310-error-in-unziping-files-loop

编辑： Stephen23 2020-2-19

采纳的回答： Stephen23

在 MATLAB Online 中打开

Hello,

I want to create a code that

Choose a folder
Unzip .zip in that folder
Delete some files with specific size

Below is my code.

files = fullfile(matlabroot, '\toolbox');
if ~exist(files, 'dir')
	files = matlabroot;
end
uiwait(msgbox('Pick a folder on the next window that will come up.'));
selpath = uigetdir(files);
if selpath == 0
	return;
end
projectdir = selpath;   
dinfo = dir( fullfile( projectdir, '**', '*.zip') );   %find all .zip underneath the projectdir.
%then
for K = 1 : length(dinfo)
   unzip( dinfo(K).name, dinfo(K).folder );  
end
files = dir(projectdir);
deletedfiles = 0;
for itr = 1:length(files)
    if files(itr).bytes<200000 && ~files(itr).isdir 
        files.name
        delete(fullfile(files(itr).folder, files(itr).name))
        deletedfiles=deletedfiles+1;
    end
end
deletedfiles

But I got an error in the unzipping part.

>> cobacoba
Index exceeds matrix dimensions.
Error in cobacoba (line 14)
   unzip( dinfo(K).name, dinfo(K).folder );
   

Any ideas what should I do?

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Walter Roberson 2020-2-19

Check your variables. You might have a variable named unzip

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Stephen23 2020-2-19

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/506310-error-in-unziping-files-loop#answer_416279

编辑：Stephen23 2020-2-19

在 MATLAB Online 中打开

You need to include the path in the filenames otherwise MATKAB does not know where to find those files, e.g.:

unzip(fullfile(dinfo(K).folder,dinfo(K).name),...);

You should also use numel, not length:

for K = 1:numel(dinfo)

I would regard any code that uses length as inherently buggy. This is a good example. Read the dir and length documentation and then think of what length returns when no files are returned by dir. Test it yourself.

Instead of buggy length you should use numel or size (requesting a specific dimension).

"Any ideas what should I do?"

Use whos and which to check if you have a variable defined named unzip.

2 个评论
显示无隐藏无

Walter Roberson 2020-2-19

dir always returns a struct vector, never a 2d array. length is well defined for it. If no files are found then length will be empty and the loop body would not execute. There is no problem using length in this context.