ismember function too slow
显示 更早的评论
I have to improve the speed of my simulation. Well my code is quite simple. I have a vector A=[1 2 3 4 5 6 7 8 9 10] and another vector B=[3 4 9]. I use ismember to check if every element is into A matrix.
for n=1:length(A)
if ismember(B(n),A)
do-something
end
end
this part of my code is executed so many time in my simulation and my matrices are really big.some idea to improve my code?
1 个评论
Matt J
2012-10-17
Since this is speed-critical, it would be wise for you to elaborate on "do-something". That could point the way to eliminating the for-loop altogether, or some other kind of performance optimization.
回答（5 个）
Jonathan Epperl
2012-10-17
Don't you want to actually INTERSECT A and B? If so, then here's a very fast intersect function that intersects two sets of positive integers only. If you have negative integers you could obviously shift. If you have reals you're SOL. If your integers are greater than ~1e5 the speed gain is negligible.
C = fastintersect(A,B)
if ~isempty(A)&&~isempty(B)
P = zeros(1, max(max(A),max(B)) ) ;
P(A) = 1;
C = B(logical(P(B)));
else
C = [];
end
Obviously you could leave out the check for emtpy sets if you know you won't have empty sets.
4 个评论
Sean de Wolski
2012-10-17
Or you could just use the various outputs from MATLAB's intersect
Jonathan Epperl
2012-10-17
编辑：Jonathan Epperl
2012-10-17
Speed was the issue here, and above suggestion beats intersect by a lot -- the disadvantage is that you're restricted to integers.
Shengtao Wang
2013-2-20
Great! A 50 times speedup for me!
Shengtao Wang
2013-2-20
Note this may produce the same number multiple times if they are not unique in the arrays. not a problem at all though.
Matt Fig
2012-10-17
BinA = B(ismember(B,A));
for n=1:length(BinA)
do-something with BinA(n)
end
2 个评论
Salvatore Mazzarino
2012-10-17
If your B vector contains ONLY elements of A, then why were YOU checking if each element was a member in your code?? That is just weird.
If you know that every element of B is a member of A, then what is the point of your question?? Why not just get rid of the IF statement in your FOR loop altogether??
Azzi Abdelmalek
2012-10-17
编辑：Azzi Abdelmalek
2012-10-17
use ismember out of the loop
A=[1 2 3 4 5 6 7 8 9 10]
B=[3 4 11 9 22]
idx=find(ismember(B,A)==1)
for k=idx
%do
end
Robert Cumming
2012-10-17
if you want to keep it in the loop you can do:
for n=1:length(B)
if min (abs( A-B(n)) ) == 0;
% do something
end
end;
Or use logical indexing
tic
A=[1 2 3 4 5 6 7 8 9 10];
B=[3 4 11 9 22];
idx=find(ismember(B,A)==1);
toc
tic
flags = false(1,length(B));
for i=1:length(A)
check = B==A(i);
flags(check)=1;
end
idx2 = find(flags==1);
toc
A for loop can be faster!!
Omar Ali Muhammed
2021-3-3
0 个投票
A=[1 2 3 4 5 6 7 8 9 10];
B=[3 4 9];
tt=ismember(B,A);
if sum(tt)==3
Do Something;
else
Do Something;
end
类别
在 帮助中心 和 File Exchange 中查找有关 Loops and Conditional Statements 的更多信息
2012-10-17
2021-3-3
Community Treasure Hunt
Find the treasures in MATLAB Central and discover how the community can help you!
Start Hunting!
Translated by 
