Help with FOR to PARFOR conversion

Question

dsmalenb 2020-8-7

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/576763-help-with-for-to-parfor-conversion

评论： Walter Roberson 2020-8-8

Hi there!

I have looked at several examples on how to convert a for loop into a parfor but for some reason I cannot get mine working. I have supplied an example of what I have working in my for loop below and my attenpt at the parfor loop. It has been a little while since I have used parfors so if anyone can assist, I would be very thankful.

for j = 1:N
    j
    clear D;
    
    [signal fs] = audioread(strcat(S(j).folder, '/', S(j).name));
    signal = signal(:,1);
    
    D(:,1) = spectralCentroid(signal,fs);
    D(:,2) = abs(spectralSlope(signal,fs));
    D = D./max(D);
 
    D(any(isnan(D), 2), :) = [];
end

parfor j = 1:N
    j
    
      
    [signal fs] = audioread(strcat(S(j).folder, '/', S(j).name));
    signal = signal(:,1);
    D{j}(:,1) = spectralCentroid(signal,fs);
    D{j}(:,2) = abs(spectralSlope(signal,fs));
    
    % Eliminate NaN rows
    D{j}(any(isnan(D{j}),2),:);
    
    % Normalize descriptors for hypercube
    % D = D./max(D);
end

The latter does not run If I comment out

D{j}(any(isnan(D{j}),2),:);

until I have fun the parfor and then run the follwoing in the immediate window

D{1}(any(isnan(D{1}),2),:) = [];

then it works. I am not sure why.

Thank you for your help!

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Walter Roberson 2020-8-8

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/576763-help-with-for-to-parfor-conversion#answer_476800

Every iteration you overwrite all of D. Your result is whatever was assigned in the last iteration. But the order of iterations is not not fixed for parfor, so the results would be random if the loop was permitted at all.

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Walter Roberson 2020-8-8

You are currently building values directly into parts of D{j}. You should instead build into a temporary variable, and assign the variable to D{j} once completely built.

请先登录，再进行评论。