Error in my function in my for loop

Question

Ongun Palaoglu 2020-10-7

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/607631-error-in-my-function-in-my-for-loop

评论： Ongun Palaoglu 2020-10-12

Hello I am trying to make a function. I have for inputs datetime 3 of them one of them is logical. I am trying to calcutate a number from many rows. I have for loop, my max iteration is the height of my table. I have cases for logical data part of my function to decide the final output, I am unable to put the final answer in an order as output. I am getting an error with exceeding matrix dimensions.

function [Count SensoredData] = sensor(StartDate,EndDate,PatientinResearch,LogicalDeath)
% X is start of the research.
% Y end date of the Research.
% E is number of days patient stay in the research
% Z is if death is occured or not. 
if ~isdatetime(StartDate)
   error('MyComponent:incorrectType',...
       'Error. \nInput must be a DateTime for StartDate, not a %s.',class(StartDate))
end
if ~isdatetime(EndDate)
   error('MyComponent:incorrectType',...
       'Error. \nInput must be a DateTime for EndDate, not a %s.',class(EndDate))
end
if ~isdatetime(PatientinResearch)
   error('MyComponent:incorrectType',...
       'Error. \nInput must be a DateTime for PatientinResearch, not a %s.',class(PatientinResearch))
end  
 if ~isa(LogicalDeath,'logical')
   error('MyComponent:incorrectType',...
       'Error. \nInput must be a Logical for LogicalDeath, not a %s.',class(LogicalDeath))
end
X = StartDate;
Y = EndDate;
E = PatientinResearch;
Z = LogicalDeath;
T = table();
   
% totalTimeOfResearch = caldays(between(X,Y,'days'));
% 
%     sdn1 = datenum( Y );
%     sdn2 = datenum( E ); 
%     format long
%      
[n,m] = size(X);
for i = 1 : 1 :  n
if caldays(between(X,Y,'days')) >= caldays(between(X,E,'days')) 
    
    
     switch Z
         case 0
             
           p = 0;
           
           T(i,:) = [i p];
           
         case 1
            
             p = 1;
             
             T(i,:) = [i p];
     end 
end
if caldays(between(X,Y,'days')) < caldays(between(X,E,'days'))
     switch Z
         case 0
             
            p = 1;
            
            T(i,:) = [i p];
         case 1
            
             p = 0;
             
             T(i,:) = [i p];
     end 
     
end
end
Count = T(:,1);
SensoredData = T(:,2);
end

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Jesús Zambrano 2020-10-7

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/607631-error-in-my-function-in-my-for-loop#answer_508021

在 MATLAB Online 中打开

Try to define the size of T before using it. Also, make sure that the line of code

[n,m] = size(X);

is giving you the value of n you expect.

3 个评论
显示 1更早的评论隐藏 1更早的评论

Ongun Palaoglu 2020-10-8

在 MATLAB Online 中打开

i have modified the code a little, I added size of table and disp values to see what went wrong. Now I am getting a table but its all 0s and I cannot see anyother disp under switch case functions.

function  SensoredData = sensor(StartDate,EndDate,PatientinResearch,LogicalDeath)
% X is start of the research.
% Y end date of the Research.
% E is number of days patient stay in the research
% Z is if death is occured or not. 
if ~isdatetime(StartDate)
   error('MyComponent:incorrectType',...
       'Error. \nInput must be a DateTime for StartDate, not a %s.',class(StartDate))
end
if ~isdatetime(EndDate)
   error('MyComponent:incorrectType',...
       'Error. \nInput must be a DateTime for EndDate, not a %s.',class(EndDate))
end
if ~isdatetime(PatientinResearch)
   error('MyComponent:incorrectType',...
       'Error. \nInput must be a DateTime for PatientinResearch, not a %s.',class(PatientinResearch))
end  
 if ~isa(LogicalDeath,'logical')
   error('MyComponent:incorrectType',...
       'Error. \nInput must be a Logical for LogicalDeath, not a %s.',class(LogicalDeath))
end
X = StartDate;
Y = EndDate;
E = PatientinResearch;
Z = LogicalDeath;
n = numel(X);
T = table('Size', [n 1],'VariableTypes', "logical");
disp('h')
   
% totalTimeOfResearch = caldays(between(X,Y,'days'));
% 
%     sdn1 = datenum( Y );
%     sdn2 = datenum( E ); 
%     format long
%      
for i = 1 : 1 :  n
if caldays(between(X,Y,'days')) >= caldays(between(X,E,'days')) 
    
    disp('g')
     
    switch Z
         case 0
             
           p = 0;
           
           T(i) = p;
           disp('a')
           
         case 1
            
             p = 1;
             
             T(i) = p;
             
             disp('b')
     end 
end
if caldays(between(X,Y,'days')) < caldays(between(X,E,'days'))
    
    disp('f')
    
    switch Z
         case 0
             
            p = 1;
            
            T(i) = p;
            
            disp('c')
         case 1
            
             p = 0;
             
             T(i) = p;
             
             disp('d')
     end 
     
end
SensoredData(i,1) = T(i,1);
end
end

Seth Furman 2020-10-8

编辑：Seth Furman 2020-10-8

I'm not clear on the goal of this code, but here are a few common pitfalls I notice:

Access Data in Tables

Indexing into a table always requires 2 indices, so the line "T(i) = p;" will always fail. Instead you want "T(i,1) = p;".
When assigning a non-table into a table, use curly braces instead of smooth parentheses, for example "T{i,1} = p; % OK" instead of "T(i,1) = p; % ERRORS if p isn't a table".

https://www.mathworks.com/help/releases/R2020b/matlab/matlab_prog/access-data-in-a-table.html

Prefer Vectorization

Use vectorization where possible because it's typically faster and leads to shorter code.
One example where you can add vectorization in this case is by creating SensoredData at the end of your function, instead of inside the for-loop with a simple index into T, for example "SensoredData = T(:,1);"

https://www.mathworks.com/help/releases/R2020b/matlab/matlab_prog/vectorization.html

Ongun Palaoglu 2020-10-12

Somehow I solved it, probably it is due to missing date lines

请先登录，再进行评论。

Error in my function in my for loop

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

采纳的回答

3 个评论
显示 1更早的评论隐藏 1更早的评论

更多回答（0 个）

另请参阅

类别

标签

产品

版本

Community Treasure Hunt

Error in my function in my for loop

0 个评论 显示 -2更早的评论隐藏 -2更早的评论

采纳的回答

3 个评论 显示 1更早的评论隐藏 1更早的评论

更多回答（0 个）

另请参阅

类别

标签

产品

版本

Community Treasure Hunt

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

3 个评论
显示 1更早的评论隐藏 1更早的评论