Function is not working

1 次查看（过去 30 天）
MadjeKoe
MadjeKoe 2020-10-13
编辑： Stephen23 2020-10-14
Hi all! I have to make the following function work. Can someone please help me??? I've been sitting on it all day long and I know that there a mistakes in it, but I do not know how to fix them.
ori4 = res(:,3);
ori3 = res(:,4);
ori2 = res(:,5);
ori1 = res(:,6);
targets = res(:,7);
responses = res(:,8);
resp1 = responses(targets==1);
resp2 = responses(targets==2);
resp3 = responses(targets==3);
resp4 = responses(targets==4);
function [err] = rerange(responses, ori, targets, target)
resp = responses(targets==target);
ori_new = ori(targets==target);
err = resp(targets==target) - ori_new(targets==target);
err(err<-90) = err(err<-90)+180;
err(err>90) = err(err>90)-180;
end
  5 个评论
显示 3更早的评论
Stephen23
Stephen23 2020-10-14
@Maddy Koenraad: what value/s does target have?

请先登录，再进行评论。

请先登录，再回答此问题。

回答（1 个）

Stephen23
Stephen23 2020-10-14
编辑：Stephen23 2020-10-14
The basic problem is that you keep repeating the same indexing, e.g.:
resp = responses(targets==target);
..
err = resp(targets==target)
but note that resp is already a sub-vector of responses, which you then try to use exactly the same index again. If resp is a smaller subvector then it is quite likely that the second time you use that index will throw an error (as it does with your example data). The solution is to only index once , after which you can just keep using the subvector for anything.
I also replaced those anti-pattern numbered variables with basic indexing. Do NOT number variables like that.
This runs without error (only you can check if it does what you want):
S = load('simulated_serial_bias_dataset.mat');
res = S.res;
targets = res(:,7);
responses = res(:,8);
orx = [3,4,5,6];
tgt = [1,2,3,4];
num = numel(orx);
out = cell(1,num);
for k = 1:num
idx = targets==tgt(k);
resp = responses(idx);
ori = res(idx,orx(k));
err = resp - ori;
err(err<-90) = err(err<-90)+180;
err(err>90) = err(err>90)-180;
out{k} = err;
end
out = [out{:}]; % optional

类别

在 Help Center 和 File Exchange 中查找有关 Data Type Conversion 的更多信息

标签

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by