My code taking too much time

2 次查看（过去 30 天）

显示更早的评论

Mr.Chandler 2020-11-16

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/649703-my-code-taking-too-much-time

编辑： Mr.Chandler 2020-11-16

采纳的回答： Jon

在 MATLAB Online 中打开

Here is my code. How can I reduce that time without changing the result?

clear all;clc;close all;
L=1000;
c = randn(1,1000000);
cont3 = 1;
while cont3 < length(c)+1
    if(abs(c(cont3)) < 1 || abs(c(cont3)) > 10)
        c(cont3) = randn(1);
        cont3 = 0;
    end
    cont3 = cont3+1;   
end
c;

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

采纳的回答

Jon 2020-11-16

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/649703-my-code-taking-too-much-time#answer_546238

编辑：Jon 2020-11-16

在 MATLAB Online 中打开

You can operate on the entire vector using for example

a(a<1) = randn

So you could make a loop something like

while any(a<1) || any(a>10)
    a(a<1) = randn(sum(a<1),1)
    a(a>10) = randn(sum(a>10),1)
end

5 个评论
显示 3更早的评论隐藏 3更早的评论

Jon 2020-11-16

在 MATLAB Online 中打开

Sorry I didn't look at your specification carefully. Anyhow you should be able to modify

while any(abs(a)<1) || any(abs(a)>10)
    condition1 = abs(a) < 1;
    a(condition1) = randn(sum(condition1),1);
    
    condition2 = abs(a) > 10;
    a(condition2) = randn(sum(condition2),1);
end