Can someone explain me how to make this loop efficiently?

1 次查看（过去 30 天）
Santos García Rosado
评论： Santos García Rosado 2021-2-18
Hello Mathworks community!
I'm having a bit of trouble trying to code a for loop. This is my code so far.
randomNumber1 = 100;
randomNumber2 = 150;
out(1)= 0;
B = 4;
for idx = 2:1:numel(A)
if idx <=(B)
ArrayValue = SomeArray(1);
if % first condition
out(idx) = ((out(idx - 1)) - randomNumber1);
elseif % second condition
out(idx) = ((out(idx - 1)) - randomNumber2);
elseif % third condition
out(idx) = (out(idx - 1) + ArrayValue);
end
elseif idx >(B) && idx <= (2*B)
ArrayValue = SomeArray(2);
if % first condition
out(idx) = ((out(idx - 1)) - randomNumber1);
elseif % second condition
out(idx) = ((out(idx - 1)) - randomNumber2);
elseif % third condition
out(idx) = (out(idx - 1) + ArrayValue);
end
elseif idx >(2*B) && idx <= (3*B)
ArrayValue = SomeArray(3);
% It keeps going until I've used every "SomeArray" value
end
end
As you can see, I have to repeat all the statements as many times as values I have inside my vector: SomeArray
The code works as it should, but I'm well awared that this is not how you do it properlly. I know aswell that it is possible to only state the conditions one time, I'm just not sure how to do it.
Could someone help me out?
Thank's!
Santos

请先登录，再回答此问题。

采纳的回答

Jon
Jon 2021-2-17
I think the key is coming up with an expression that gives you the index for someArray from the current loop index. Something like this:
randomNumber1 = 100;
randomNumber2 = 150;
out(1)= 0;
B = 4;
for idx = 2:1:numel(A)
k = ceil(idx/4); % index into someArray
ArrayValue = SomeArray(k);
if % first condition
out(idx) = ((out(idx - 1)) - randomNumber1);
elseif % second condition
out(idx) = ((out(idx - 1)) - randomNumber2);
elseif % third condition
out(idx) = (out(idx - 1) + ArrayValue);
end
end
  2 个评论
Jon
Jon 2021-2-17
Also you should preallocate your our array to the final size it will reach, you just make it one element long.
So
out = zeros(size(2:1:numel(A)));
Santos García Rosado
Santos García Rosado 2021-2-18
Thank you Jon! Your code was what i was looking for. Indeed, I had preallocated the array but I forgot to cipying it down on the answer. Thank's again.

请先登录，再进行评论。

更多回答（1 个）

Rik
Rik 2021-2-17
编辑：Rik 2021-2-17
Your intuition is correct; this can indeed be simplified:
for k=1:numel(SomeArray)
if idx <= (k*B)
ArrayValue = SomeArray(k);
%your other code
break%stop the for loop with k
end
end

类别

在 Help Center 和 File Exchange 中查找有关 Matrix Indexing 的更多信息

标签

产品


版本

R2020b

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by