I have this for loop, and it seems to not end.

Question

Josiah Jarenee Comia 2021-5-13

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/828943-i-have-this-for-loop-and-it-seems-to-not-end

编辑： Pranav Verma 2021-5-17

for i=1:n
   Phi1=1;
   Phi2=1;
   gamma1calc(i)=exp(alpha/(1+(alpha/beta)*(x1(i)/x2(i)))^2);
   gamma2calc(i)=exp(beta/(1+(beta/alpha)*(x2(i)/x1(i)))^2);
   Pcalc(i) = ((x1(i)*gamma1calc(i)*P1sat)/(Phi1))+((x2(i)*gamma2calc(i)*P2sat)/(Phi2));
   AE1(i)=1;
        while AE1(i) > 0.0001
            y1calc(i) = (x1(i)*gamma1calc(i)*P1sat)/(Phi1);
            y2calc(i) = 1-y1calc(i);
    
            Phi1calc(i)=exp((B1.*(Pcalc(i)-P1sat)+Pcalc(i).*y2calc(i).^2.*(2.*B12-B1-B2))./(R*T));
            Phi2calc(i)=exp((B2.*(Pcalc(i)-P2sat)+Pcalc(i).*y1calc(i).^2.*(2.*B12-B1-B2))./(R*T));
            Pnew(i) = ((x1(i)*gamma1calc(i)*P1sat)/Phi1calc(i))+((x2(i)*gamma2calc(i)*P2sat)/Phi2calc(i));
            AE2 (i)=abs(Pnew(i)-Pcalc(i));
                if AE2(i) > 0.0001
                     Pcalc(i)=Pnew(i);
                end
        end
    Pcalc(i)=Pnew(i);    
end

3 个评论
显示 1更早的评论隐藏 1更早的评论

Josiah Jarenee Comia 2021-5-13

在 MATLAB Online 中打开

My bad, I entered the wrong code, I just tested that because im not getting anything. Here's the original. This should work right? I mean the loop structure is correct and all right?

for i=1:n
   Phi1=1;
   Phi2=1;
   gamma1calc(i)=exp(alpha/(1+(alpha/beta)*(x1(i)/x2(i)))^2);
   gamma2calc(i)=exp(beta/(1+(beta/alpha)*(x2(i)/x1(i)))^2);
   Pcalc(i) = ((x1(i)*gamma1calc(i)*P1sat)/(Phi1))+((x2(i)*gamma2calc(i)*P2sat)/(Phi2));
   AE1(i)=1;
        while AE1(i) > 0.0001
            y1calc(i) = (x1(i)*gamma1calc(i)*P1sat)/(Phi1);
            y2calc(i) = 1-y1calc(i);
            Phi1calc(i)=exp((B1.*(Pcalc(i)-P1sat)+Pcalc(i).*y2calc(i).^2.*(2.*B12-B1-B2))./(R*T));
            Phi2calc(i)=exp((B2.*(Pcalc(i)-P2sat)+Pcalc(i).*y1calc(i).^2.*(2.*B12-B1-B2))./(R*T));
            Pnew(i) = ((x1(i)*gamma1calc(i)*P1sat)/Phi1calc(i))+((x2(i)*gamma2calc(i)*P2sat)/Phi2calc(i));
            AE1(i)=abs(Pnew(i)-Pcalc(i));
                if AE1(i) > 0.0001
                     Pcalc(i)=Pnew(i);
                end
        end
    Pcalc(i)=Pnew(i);    
end

Stephen23 2021-5-13

"This should work right?"

You did not describe the intended algorithm, so I have no way to check if it is implemented correctly or should "work".

"I mean the loop structure is correct and all right?"

That looks like the correct syntax for a WHILE loop.

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Pranav Verma 2021-5-17

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/828943-i-have-this-for-loop-and-it-seems-to-not-end#answer_701628

编辑：Pranav Verma 2021-5-17

Hi Josiah,

I would recommend you to print out the value of AE1(i) inside the loop along with appropriate messages. This will allow you to watch the value of AE1(i) and debug the code easily.

You can use disp function to print out the value and messages.

Thanks