Saving function variables without evil eval

2016 11 29
3 个回答
更新时间：2021 7 22
8 次查看（30 天）

0 个投票

Note: I am aware that using eval is usually not a good practice. However for me it is very difficult to understand when it can be used and when not.
Question: So my question is, is this a proper usage? and if not how should I do it differently?
Background: I have a function that occasionally crashes (not going in to detail in this question) As it is run after 30 minutes of simulation I want to avoid re-running the simulation. So I though of a checkpoint at the start of the function in which all variables are saved, in case it fails.
Code: I start of saving all variables to base workspace (could be a .mat file if thats prefered)
function test(var1, var2, var3, var4, ....)
.
.
.
%Temporary store results to workspace
variables = who;
for ii = 1:length(variables);
insurance.(variables{ii}) = eval(variables{ii});
end
assignin('base','insurance',insurance)
For convenience I saved all variables in to a single struct, but even if I saved them seperatly, I cannot think of a way to avoid eval in this situation.
Code part 2: The user now can (try) to re-run by calling the function "test(insurance)", which will restore the saved variables
function test(var1, var2, var3, var4, ....)
% load temporary stored results to m-file
if nargin == 1
insurance = var1;
names = fieldnames(insurance);
for ii = 1:length(names)
feval(@()assignin('caller',names{ii},insurance.(names{ii})))
end
end

2 个评论
显示 无 隐藏 无

Remco1988
Remco1988 2016-11-29
now that I think of it at home, might be much better to change the entire function to a varargin input? in that way I do not need to rewrite everything twice to save/load variables.
function test(varargin)
% load temporary stored results to m-file
if nargin == 1
varargin = varargin{1} % rewrite varargin to default input order
end
%Temporary store results to mat-file
save(fname,varargin) % saves 1xN cell to mat file
var1 = varargin{1};
var2 = varargin{2};
....
less readable, but better I guess
Bardo Mueller
Bardo Mueller 2021-7-22
should be
save(fname, 'varargin')

请先登录，再进行评论。

请先登录，再回答此问题。

回答（3 个）

dpb
dpb 2016-11-29

3 个投票

Just save then load will do all automagically...see
doc save % for details

2 个评论
显示 无 隐藏 无

Remco1988
Remco1988 2016-11-29
i could use save and load "insurance" instead of assigning to the base workspace, but this does not resolve my 'eval' part of the code.
dpb
dpb 2016-11-29
编辑：dpb 2016-11-29
Why? What do you need eval for if you just save and restore the variables as they were? Don't see the issue, sorry...
function YourRescueFunction(insurance)
load insurance
results=TheOriginalFunction(variablesFromInsuranceReloaded);
Actually, if you were to wrap the above around the initial and make it a nested function within the recovery routine, then everything in it is also local within the original and you don't even have an issue of workspace at all it would seem...

请先登录，再进行评论。

Jan
Jan 2016-11-29

1 个投票

Use a function and not scripts, which pollute the base workspace with variables. Then you can use save to store all current variables, but not any other stuff of the base workspace. But even if you use save in scripts: There is no need for eval at all.
Alexandra Harkai
Alexandra Harkai 2016-11-29
编辑：Alexandra Harkai 2016-11-29

0 个投票

How about having all these state variables in a struct in the first place? Then you can save them to a mat file, for example:
var_struct.var1 = <some_value>;
var_struct.var2 = <some_other_value>;
...
fname = [datestr(now,'yymmdd_HHMMSS'), '.mat'];
save(fname, '-struct', 'var_struct', '-v7.3');

1 个评论
显示 -1更早的评论 隐藏 -1更早的评论

Remco1988
Remco1988 2016-11-29
编辑：Remco1988 2016-11-29
It is a possibility, but would you suggest either creating a struct within the function from the different inputs:
test(var1, var2, var3, var4, ....)
if nargin == 1 % user running struct
var_struct = var1;
var1 = var_struct.var1;
var2 = var_struct.var2;
...
else
var_struct.var1 = var1;
var_struct.var2 = var2;
...
save(fname, var_struct) % make checkpoint
end
or have a function that only allows a single struct input in the first place:
save(fname, var_struct)
test(var_struct) % run function
.
test(var_struct)
var1 = var_struct.var1;
var2 = var_struct.var2;
....
the first one is clunky with a lot of inputs (thats why I created a for loop). The 2nd one is more elegant, but I don't think functions with a struct input are good practice either?

请先登录，再进行评论。

类别

在 帮助中心 和 File Exchange 中查找有关 Variables 的更多信息

标签

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by