Once more... Avoid global variable!

Question

Rafael Kübler 2017-11-29

2
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/369955-once-more-avoid-global-variable

评论： Rafael Kübler 2017-11-30

Hello together,

I'm writing many function which i often use during a matlab session. To make them a little more compfortalbe to use i'd like to use a data structure in some way, where i can store some preference data. The preference data is for example some input arguments the functions have in common. But because the values of these input arguments change from time to time, so i can not set it as default values in the function.

Global variables look perfect for this task, but i've read a lot of comments that global variables are bad and i'd rather avoid using them. But what other ways are there, to store my preference data and use it in different functions.

thank you for your help.

Rafael

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Jan 2017-11-29

This is a good question, +1. You state "Global variables look perfect for this task". The magic core in this formulation is "look": In fact, globals look like they solve the problems and they really do so - but in a long term view they will cause even more troubles, which can grow to a such severe level, that the code cannot be debugged or maintained anymore.

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Jan 2017-11-29

2
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/369955-once-more-avoid-global-variable#answer_293756

在 MATLAB Online 中打开

You can create a "global function" to store static parameters:

function G = theGlobalData()
G.pi   = 3.14;
G.imag = 1i;
G.PIN  = 5553;
end

You might add some input arguments also or store G persistently:

function G = theGlobalData(Name, Value)
persistent G_
if isempty(G_)
  G_.pi   = 3.14;
  G_.imag = 1i;
  G_.PIN  = 5553;
end
if nargin > 0 
  G_.(Name) = Value;
end
G = G_;
end

This shares the problem of global variables, that e.g. running multiple instances of your program can cause collisions of the values. But at least you can debug each access of this function. Setting a breakpoint in it allows to track all events.

I'd prefer sharing the struct inside the code by using input and output arguments. Passing an additional argument is neither clumsy nor slow and there is no danger of interferences with other instances of your code or other software.

These ideas are "create a parameters function" and "pass a struct" of Stephen's answer.

7 个评论
显示 5更早的评论隐藏 5更早的评论

Jan 2017-11-29

编辑：Jan 2017-11-29

在 MATLAB Online 中打开

@Rafael: Storing the struct for the next Matlab session is fine, e.g.:

function G = YourGlobalFcn(Name, Value)
persistent G_
if isempty(G_)
  % Check if Matlab know the preferences already:
  if ispref('Rafael', 'G_')
    fprintf('::: Loading global data from file\n');
    G_ = getpref('Rafael', 'G_');
  else  % Running the first time:
    G_.pi   = 3.14;
    G_.imag = 1i;
    G_.PIN  = 5553;
  end
  mlock;  % Block "clear all" to delete G_
end
if nargin == 2
   G_.(Name) = Value;
elseif nargin == 1
   if strcmpi(Name, 'save')
      fprintf('::: Saving global data to file\n');
      setpref('Rafael', 'G_', G_);
   elseif strcmpi(Name, 'load')
      G_ = getpref('Rafael', 'G_');
   else
      error('Rafael:YourGlobalFcn:BadCommand', ...
            'Unknown command: %s', Name);
   end
end
G = G_;
end

Now insert "YourGlobalFcn('save')" to your "finish.m" file. Then G_ is stored persistently between Matlab sessions and restored automatically.

But again: Running e.g. two Matlab sessions can cause conflicts and you cannot control, in which one the last changes have been made. Use it with care: All methods to store data globally can drill a hole in your knee. Storing parameters individually e.g. for each instance of a GUI or for each Matlab session might be useful. But this depends on your code also.

Stephen23 2017-11-29

Yes. Try it.

Rafael Kübler 2017-11-30

Oh, yes it works however now.

请先登录，再进行评论。

Answer 2

Image Analyst 2017-11-29

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/369955-once-more-avoid-global-variable#answer_293750

Perhaps start with the faq: http://matlab.wikia.com/wiki/FAQ#Are_global_variables_bad.3F

and

http://matlab.wikia.com/wiki/FAQ#How_can_I_share_data_between_callback_functions_in_my_GUI.28s.29.3F

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

Answer 3

Jos (10584) 2017-11-29

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/369955-once-more-avoid-global-variable#answer_293758

在 MATLAB Online 中打开

Take a look at the setappdata and getappdata. You can use the root handle to store variables.

setappdata(0,'MyVar',1:10)

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

Answer 4

per isakson 2017-11-29

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/369955-once-more-avoid-global-variable#answer_293762

编辑：per isakson 2017-11-29

在 MATLAB Online 中打开

Download parse_pv_pairs by John D'Errico and run this example

preference.Viscosity = 1;
preference.Volume = 1;
preference.Pie = 3.141592653589793;
preference.Description = 'test';
params = examplefun( preference, 'Viscosity',2, 'Volume',3 );

and inspect params

>> params
params = 
      Viscosity: 2
         Volume: 3
            Pie: 3.1416
    Description: 'test'

where

function    ip = examplefun( nv, varargin )
     ip = parse_pv_pairs( nv, varargin );
end

In examplefun you refer to the input arguments as ip.Viscosity, ip.Volume, ip.Pie and ip.Description.

This example doesn't fully meet your requirements, since the structure, preference, must contain all fields.

This solution may be developed further. Download CATSTRUCT, by Jos (10584) and run this modified example

preference.Viscosity = 1;
preference.Pie = 3.141592653589793;
params = examplefun( preference, 'Viscosity',2 );

and inspect params carefully

params = 
    Description: 'Default values'
            Pie: 3.1416
      Viscosity: 2
         Volume: 12
>>

where

function    ip = examplefun( nv, varargin )
      warning('off','catstruct:DuplicatesFound')
      default.Viscosity = 11;
      default.Volume = 12;
      default.Pie = 3.141592653589793;
      default.Description = 'Default values';
      nv = catstruct( default, nv );
      ip = parse_pv_pairs( nv, varargin );
  end