Is there any way to make this code faster?

Question

Qingyang 2012-7-17

1
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/43833-is-there-any-way-to-make-this-code-faster

Hi, I have this code that tosses out pixels from a cc list

    for i = 1:cc.NumObjects
        for j = length(cc.PixelIdxList{i}):-1:1
            ind = cc.PixelIdxList{i}(j);
            if ~imdiff(ind) || ~imcombined(ind)
                cc.PixelIdxList{i}(j) = [];
            end
        end
    end

imdiff and imcombined are both images. The code at the moment takes quite a while to churn through a decent sized image. Is there any way to make this code run faster?

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Daniel Shub 2012-7-17

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/43833-is-there-any-way-to-make-this-code-faster#answer_53782

I think this is a memory allocation issue. Every time you set cc.PixelIdxList{i}(j) = [], MATLAB needs to allocate new memory. You might be better off building an array that holds the indices to remove, and then removing them at the end.

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Qingyang 2012-7-17

在 MATLAB Online 中打开

Thanks! I tried what you suggested and it reduced the execution time by a ton! Here's the revised code:

      for i = 1:cc.NumObjects
          indices = false(length(cc.PixelIdxList{i}));
          for j = 1:length(cc.PixelIdxList{i})
              ind = cc.PixelIdxList{i}(j);
              if ~imdiff(ind) || ~imcombined(ind)
                  indices(j) = true;
              end
          end
          cc.PixelIdxList{i}(indices) = [];
      end

This works great but if you have any other suggestions to make it run even faster, please tell!

请先登录，再进行评论。

Answer 2

Sean de Wolski 2012-7-17

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/43833-is-there-any-way-to-make-this-code-faster#answer_53790

编辑：Sean de Wolski 2012-7-17

在 MATLAB Online 中打开

That whole thing should be vectorizable assuming imdiff and imcombined (whatever those are) can handle it:

cellfun(@(c)c(imdiff(c)&imcombined(c)),CC.PixelIdxList,'uni',false)

3 个评论
显示 1更早的评论隐藏 1更早的评论

Sean de Wolski 2012-7-17

No. I just like it :)

You could keep the outer for-loop just as easily. The point is that the inner for-loop does not need to check each value if imdiff and imcombined are either images or functions that can be passed vector inputs.

Qingyang 2012-7-17

Hi, thanks for the reply. I'm not quite familiar with that type of coding, but it did not give what I intended when I used it in place of the original code. I'm sure its probably just a small tweak that I'm can't tell. But, thanks anyways and I've got the code working much faster based on a suggestion from another commenter.

请先登录，再进行评论。