Please advise me on how to improve the efficiency of this code?

Question

Yong Loong Chan 2019-3-12

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/449571-please-advise-me-on-how-to-improve-the-efficiency-of-this-code

评论： Rik 2019-3-14

As the title says, how can i improve on this on the code on the second line?

try_again = input('Do you want to try again?\nPlease enter yes or no:','s');
 while strcmp(try_again,'') == 1 | strcmp(try_again,'yes') ~= 1 | strcmp(try_again,'y') ~= 1 |strcmp(try_again,'no') ~= 1 | strcmp(try_again,'n')  ~= 1 
     try_again = input('Please enter yes or no:','s');
     if strcmp(try_again,'yes') | strcmp(try_again,'y')
         scriptA
     elseif strcmp(try_again,'no') | strcmp(try_again,'n')
         break
     end
 end

Any help or tips would be very greatful, thank you very much

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

darova 2019-3-12

在 MATLAB Online 中打开

while strcmp(try_again,'') == 1 | strcmp(try_again,'yes') ~= 1 | strcmp(try_again,'y') ~= 1 |strcmp(try_again,'no') ~= 1 | strcmp(try_again,'n')  ~= 1 

while isempty( strfind('yesno',try_again) )

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Rik 2019-3-12

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/449571-please-advise-me-on-how-to-improve-the-efficiency-of-this-code#answer_364986

在 MATLAB Online 中打开

You could use an explicit dialog box to avoid any confusion:

answer = questdlg(...
    'Do you want to try again?', ...%question body
    'Retry?', ...%box title
    'Yes','No', ...%options
    'Yes');%default
if strcmp(answer,'Yes')
    scriptA
end

If a GUI option is not acceptable you can use something similar to the suggestion by darova:

options={'yes',1;'y',1;'no',0;'n',0};
try_again = input('Do you want to try again?\nPlease enter yes or no:','s');
L=ismember(options(:,1),try_again);
while ~any( L )
    try_again = input('Do you want to try again?\nPlease enter yes or no:','s');
    L=ismember(options(:,1),try_again);
end
if options{L,2}
    scriptA
end

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Rik 2019-3-14

Did this suggestion solve your problem? If so, please consider marking it as accepted answer. It will make it easier for other people with the same question to find an answer. If this didn't solve your question, please comment with what problems you are still having.

请先登录，再进行评论。