Is there a shorter/smarter way to do this code

Question

Itzik Ben Shabat 2012-11-7

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/53019-is-there-a-shorter-smarter-way-to-do-this-code

Hi, I am trying to creat a matrix of all possible coordinates given 2 coordinate vectors. my code is attached below. I know there is a better way to do this. can anyone help?

 n=8 %can be any number
  Ycoord=[0.5:n-0.5];
  Xcoord=[0.5:n-0.5];
  for i=1:n
  for j=1:n
  handles.coordinates{i,j}={Xcoord(i),Ycoord(j)};
  end
  end

thanks

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Jan 2012-11-7

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/53019-is-there-a-shorter-smarter-way-to-do-this-code#answer_64580

编辑：Jan 2012-11-7

在 MATLAB Online 中打开

No, there is no "better" way, as long as you want to store the data in a cell array. You could use mat2cell, but then the same loops are performed inside this function also. One small improvement is to omit the unnecessary square brackets around the vectors (MLint should mention this already):

Ycoord = 0.5:n-0.5;
Xcoord = 0.5:n-0.5;

If you could store the values in a numerical array, simplifications are possible:

nX = length(Xcoord);
nY = length(Ycoord);
handles.coordinates = cat(3, repmat(Ycoord, nX, 1), repmat(Xcoord', 1, nY));

Then an pair of coordinates is restored by:

C = squeeze(handles.coordinates(i, j, :));

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

Answer 2

Daniel Shub 2012-11-7

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/53019-is-there-a-shorter-smarter-way-to-do-this-code#answer_64581

It depends what you mean by better. To me the best code is the the code that is easiest for me to maintain unless it is a time bottleneck. If the maintainable code makes my overall function take too long, then I look into optimizing.

For your code, I would preallocate handles.coordinates and probably save the data as doubles instead of a cell array. As for eliminating the loops, you can and you will see an improvement, but then the code might be less readable and harder to maintain for you. For n equal to 8 (or any number of that order of magnitude) efficiency doesn't really matter unless you are calling the code a lot.