Is there a way to vectorize the 3 for loops?

Question

Navneet 2013-3-10

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/66565-is-there-a-way-to-vectorize-the-3-for-loops

 for k=1:1:scolr
    for j=1:1:scols
        for i=1:1:srows
            %Binary Conversion
            esecretbin=dec2bin(secret(i,j,k),8);
            esecreth(1:8)=str2num(esecretbin(:));
            %Partial Share Generation
            eoshare1{i,j}=esecreth;
            %Dummy Initialization
            cr=0;
            zr=0;
            %Random Integer Generation
            ra{i,j,k}=randint(1,1,9);
            while ra{i,j,k}==0
                ra{i,j,k}=randint(1,1,9);
            end
            %Checking for 1s and 0s and replacing alternative 1s
            for a=1:1:8
                if eoshare1{i,j}(a)==1
                    o{i,j}=o{i,j}+1;        
                    cr=cr+1;
                    if mod(o{i,j},2)==0;    
                        eoshare1{i,j}(a)=0; 
                        c{i,j}(a)=a;        
                        insert1=1;
                        insert2=0;
                    else
                        c{i,j}(a)=0;       
                        insert1=0;
                        insert2=1;
                    end
                else
                    z{i,j}=z{i,j}+1;       
                    c{i,j}(a)=0;           
                    zr=zr+1;
                end
                if (cr<zr && insert1==0) || (cr<zr && insert1==1)
                    if c{i,j}(a)~=a
                        if eoshare1{i,j}(a)==0 && a~=ra{i,j,k}
                            eoshare1{i,j}(a)=1;
                            cr=cr+1;
                            zr=zr-1;
                        end
                    end
                else if cr==zr && insert1==0
                        if c{i,j}(a)~=a
                            if eoshare1{i,j}(a)==0 && a~=ra{i,j,k}
                                eoshare1{i,j}(a)=1;
                                cr=cr+1;
                                zr=zr-1;
                            end
                        end
                    end
                end
                if cr>zr && insert1==0
                    break;
                else if cr==zr && insert1==1
                        break;
                    end
                end
            end
            %Performing bitxor to obtain Old Share2
            eoshare2{i,j}=bitxor(eoshare1{i,j},esecreth);
            %Insertion of the selected number at the random location in share1
            enshare1{i,j}(1:ra{i,j,k}-1)=eoshare1{i,j}(1:ra{i,j,k}-1);
            enshare1{i,j}(ra{i,j,k})=insert1;
            enshare1{i,j}(ra{i,j,k}+1:9)=eoshare1{i,j}(ra{i,j,k}:8);
            %Insertion of the selected number at the random location in share2
            enshare2{i,j}(1:ra{i,j,k}-1)=eoshare2{i,j}(1:ra{i,j,k}-1);
            enshare2{i,j}(ra{i,j,k})=insert2;
            enshare2{i,j}(ra{i,j,k}+1:9)=eoshare2{i,j}(ra{i,j,k}:8);
            %Cover image enhancement
            if cover1(i,j,k)<256
                cover1(i,j,k)=cover1(i,j,k)+1;
            end
            if cover2(i,j,k)<256
                cover2(i,j,k)=cover2(i,j,k)+1;
            end
            isOne = enshare1{i,j} == 1 ;
            enshare1{i,j}(:) = cover1(i,j,k)-1 ;
            enshare1{i,j}(isOne) = cover1(i,j,k) ;
            isOne = enshare2{i,j} == 1 ;
            enshare2{i,j}(:) = cover2(i,j,k)-1 ;
            enshare2{i,j}(isOne) = cover2(i,j,k) ;
            %Reshaping into 3x3 matrix
            etshare1{i,j}=reshape(enshare1{i,j},3,3);        
            eshare1{i,j}=transpose(etshare1{i,j});           
            etshare2{i,j}=reshape(enshare2{i,j},3,3);        
            eshare2{i,j}=transpose(etshare2{i,j});           
            %Dummy initialization
            ro=(3*i)-2;
            co=(3*j)-2;
            %Replacement of cover pixels
            s11=eshare1{i,j};
            s1(ro:ro+2,co:co+2,k)=s11;
            s22=eshare2{i,j};
            s2(ro:ro+2,co:co+2,k)=s22;
        end
    end
 end

Is there any way to vectorize the 3 for loops or atleast the inner 'a' for loop?

6 个评论
显示 4更早的评论隐藏 4更早的评论

Navneet 2013-3-10

在 MATLAB Online 中打开

@Matt J

The code is actually taking in a 160x160x3 image(referred to as secret) and initially converting it into a 8 bit image.
Each of these 8bit numbers are converted into a string so that I can access each element in the string.
Either 1 or 0 is inserted in the 8 bit string and the position for insertion of this number is determined by the number generated by randint(between 1 and 9).
After the insertion of the number, I convert the alternative 1s to 0s.(The number previously inserted is not taken into consideration in this step)
In order to avoid that, I constructed this structure

   if (cr<zr && insert1==0) || (cr<zr && insert1==1)
                    if c{i,j}(a)~=a
                        if eoshare1{i,j}(a)==0 && a~=ra{i,j,k}
                            eoshare1{i,j}(a)=1;
                            cr=cr+1;
                            zr=zr-1;
                        end
                    end
                else if cr==zr && insert1==0
                        if c{i,j}(a)~=a
                            if eoshare1{i,j}(a)==0 && a~=ra{i,j,k}
                                eoshare1{i,j}(a)=1;
                                cr=cr+1;
                                zr=zr-1;
                            end
                        end
                    end
                end
                if cr>zr && insert1==0
                    break;
                else if cr==zr && insert1==1
                        break;
                    end
    end

Here c{i,j} stores the position in which the number 1 has been inserted and avoids changing the 1 which has been recently inserted.
And then, only for the share1 I make the number of 1s>number of 0s. For this I change the 0s present into 1s from the LHS of the binary number. Again the previously inserted 0 should not be changed.
Later on I perform the bitxor and concatenate with the number to be inserted and get the new matrix.
I then reshape it and so on and so forth.

I hope I haven't confused you with all those pointers.

Navneet 2013-3-10

在 MATLAB Online 中打开

@Cedric

I saw your comment and I shall try that out. However, how do I vectorize the for loops of i,j and k? I understand the similarity between my previous question and the 'a' for loop over here. Let me try it out and get back.

With regards to the profile viewer, I tried it out. I did,

profile clear
profile on
profreport('filename.m')

However, it showed No profile information.

Cedric 2013-3-10

编辑：Cedric 2013-3-10

在 MATLAB Online 中打开

>> profile viewer

and type the call of the function or script that you want to run/profile in the field Run this code. Then press enter or click on [ Start Profiling ].

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Daniel Shub 2013-3-10

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/66565-is-there-a-way-to-vectorize-the-3-for-loops#answer_78062

Why do you want to vectorize the code? Loops in MATLAB are no longer, and haven't been for a decade, inherently slow. Is your question perhaps "how can I optimize my code"? The first step is to use mlint. All those orange warning the MATLAB editor gives you are telling you important things. Once your function is all "green", it is time to use the profiler to find the bottleneck. Once you know what is slow, decide if it is worth speeding up.

5 个评论
显示 3更早的评论隐藏 3更早的评论

Daniel Shub 2013-3-11

Hopefully the checks are only a small portion of the run time and when they are not, hopefully there is already a compiled mex that runs without the checks....

Jan 2013-3-11

@Daniel: Yes, hopefully. Unfortunately a lot of functions suffer from the overhead, e.g. polyfit: Disabling the warning temporarily needs more time than the actual processing, except for "large" problems.

In MEX files the checks require much less time, but they are much more important there. Inside C a bad input can cause a corrupted memory management, while inside Matlab this does not happen.

请先登录，再进行评论。

Answer 2

Jan 2013-3-10

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/66565-is-there-a-way-to-vectorize-the-3-for-loops#answer_78107

What kind of reply do you expect? I strongly recommend to use the profiler at first, or even better some TIC/TOCs, which do not disable the JIT acceleration. Then post the relevant part of the code again.

The currently posted large code is not a fair task for a forum.

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

Is there a way to vectorize the 3 for loops?

6 个评论
显示 4更早的评论隐藏 4更早的评论

回答（2 个）

5 个评论
显示 3更早的评论隐藏 3更早的评论

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

另请参阅

类别

标签

Community Treasure Hunt

Is there a way to vectorize the 3 for loops?

6 个评论 显示 4更早的评论隐藏 4更早的评论

回答（2 个）

5 个评论 显示 3更早的评论隐藏 3更早的评论

0 个评论 显示 -2更早的评论隐藏 -2更早的评论

另请参阅

类别

标签

Community Treasure Hunt

6 个评论
显示 4更早的评论隐藏 4更早的评论

5 个评论
显示 3更早的评论隐藏 3更早的评论

0 个评论
显示 -2更早的评论隐藏 -2更早的评论