parfor makes wrong computations

Question

0 个投票

hi

i've got some code that works correctly in normal mode, but outputs wrong results when run in parallel mode.

here is the simplest code i had to show you

parfor p4 = 1: 10
                s2 = ['f1.txt'];
                om2=pi*[linspace(0,0.6080,60),linspace(0.6082,1,40)];
                D2=[zeros(1,60),exp(-1i*om2(1:40)*25)];
                W2=[1000*ones(1,60),1*ones(1,1),1*ones(1,39)];
                [b2,a2,e2]=mpiir_l2(25,23,om2,D2,W2,0.98);
                Hhigh = dfilt.df1(b2,a2);
                [h w] = freqz(Hhigh, 65536);
                moy = 0;
                p2 = round((0.6086+0.0114)*65536)
                 while p2<65536+1
                    mag = abs(h(p2));
                    if (mag > 1)
                        maxx = (mag - 1);
                    end;
                    if (mag < 1)
                        maxx = (1 - mag);
                    end;
                    moy = moy + maxx;
                    p2 = p2 +1;
                end;
                moy = moy / (65536-round((0.6086+0.0114)*65536));
                f = fopen(s2, 'w');
                fprintf(f, '%d\n', p4);
                fprintf(f, 'moy(<0.007)=%f \n', moy);
                fclose(f);
end;

thanks

Jeff

2 个评论
显示无隐藏无

Matt J 2013-10-6

编辑：Matt J 2013-10-6

We cannot run it. The function mpiir_l2 is unavailable. You also haven't told us how we're to distinguish good output from bad.

Jean-François 2013-10-8

okay i'm sorry about that.

here is the full Matlab file: http://khaelis.com/tmp/nouveaudossier.zip

thanks for helping me

请先登录，再进行评论。

请先登录，再回答此问题。

Follow Question

Answer 1

Jan 2013-10-6

编辑：Jan 2013-10-6

1 个投票

No. The results of parfor are correct. Although this opinion is based on the title of your question only, the experiences in the Matlab forums show, that 99.9% of the assumed bugs in Matlab's core functions are caused by bugs in the program.

Opening one file for writing inside a parfor loop is not a good idea. You cannot control in which order the multiple threads are processed, so you cannot predict, which of the 10 iterations will overwrite the file the last time.

Better store the results in a cell and create the file after the loop. Beside the consistency of the result, this is important for the efficiency also. Otherwise the 10 loops compete for the resource to access the file and the collisions will reduce the speed massively.

3 个评论
显示 1更早的评论隐藏 1更早的评论

Jan 2013-10-7

@Jean-Francois: I do not get the problem. These are two completely different loops. So what are you comparing? How large is the difference? Please compare it to eps(result), whatever the result is.

We cannot see the code, we do not know the difference, then we cannot guess the problem. How can we help you?

Jean-François 2013-10-8

okay i'm sorry about that.

here is the full Matlab file: http://khaelis.com/tmp/nouveaudossier.zip

thanks for helping me

Jeff

请先登录，再进行评论。

parfor makes wrong computations

2 个评论
显示无隐藏无

采纳的回答

3 个评论
显示 1更早的评论隐藏 1更早的评论

更多回答（0 个）

类别

标签

Community Treasure Hunt

parfor makes wrong computations

2 个评论 显示 无 隐藏 无

采纳的回答

3 个评论 显示 1更早的评论 隐藏 1更早的评论

更多回答（0 个）

类别

标签

另请参阅

Community Treasure Hunt

2 个评论
显示无隐藏无

3 个评论
显示 1更早的评论隐藏 1更早的评论