Very slow for loop

Question

Rafael 2011-12-31

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/25060-very-slow-for-loop

Hi, I am new to Matlab, i have more experience with C/C++

I am trying run this simple loop:

x=zeros([10001,10001,2]);
for t=1:2
for z =1:10000
for i =1:10000
  x(z,i,t)=i+z+t+2;
end 
end
end
x(5,5,1)

But is taking a while..imagine many of then inside a single algorithm. in C++ this loop runs in a few seconds...

Is there any other way to run this loop in Matlab faster???

Sorry if my question is silly, first time running Matlab. I tried some vectorization but for nested loops things get really complicated, especially with different loop sizes.

Thanks

3 个评论
显示 1更早的评论隐藏 1更早的评论

Daniel Shub 2011-12-31

Why should that be any faster/slower than 1:10000? The variable x is already intialized to a size that handles either case.

Andrew Newell 2011-12-31

The point of my question is that the values in each row and column increase until they suddenly drop to zero at the end. I'm guessing that is not what Rafael intended.

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Daniel Shub 2011-12-31

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/25060-very-slow-for-loop#answer_32916

You might be able to get a slight performance boost by changing how the memory is acessed ...

http://undocumentedmatlab.com/blog/matrix-processing-performance/

Basically x(z,i,t) might not be the same as x(t,z,i) or x(i,z,t).

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Rafael 2011-12-31

Hi Daniel, Thanks!!! Indeed improved the permornce by 2-4 seconds but is still very slow, almost 25 seconds, on my machine (not a powerful one though). Running it using C++ on GCC 4.6 (with architecture and performance flags optimized) it runs in 3 seconds. The difference is huge. Thanks anyway and happy new year (not yet in Brazil - almost 5 hours to go)!!!!

请先登录，再进行评论。

Answer 2

the cyclist 2012-1-1

1
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/25060-very-slow-for-loop#answer_32928

在 MATLAB Online 中打开

x = bsxfun(@plus,bsxfun(@plus,1:10000,(1:10000)'),permute(1:2,[1 3 2]))+2;

1 个评论
显示 -1更早的评论隐藏 -1更早的评论

Rafael 2012-1-1

Thanks!, indeed much faster!

请先登录，再进行评论。

Answer 3

Andrew Newell 2011-12-31

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/25060-very-slow-for-loop#answer_32918

在 MATLAB Online 中打开

For a problem where the numbers count upward monotonically in each direction, here is a compact and fast solution:

y = repmat(2:10002,10001,1);
x = cat(3,y+y',y+y'+1);

On my computer, your code takes about 25 seconds and mine takes 6 seconds.

2 个评论
显示无隐藏无

Rafael 2011-12-31

Hi, thanks.

As I said before, according to your feedback I have to avoid for loops in my code. Will be hard to translate C++ codes for Matlab if this is true.

Andrew Newell 2012-1-1

I think that you mostly can leave loops in because MATLAB uses just-in-time compiling on loops. However, as far as I know this compiling isn't done on arrays of dimension greater than 2.

请先登录，再进行评论。

Answer 4

Jan 2012-1-1

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/25060-very-slow-for-loop#answer_32936

If the shown code is your original problem, and not a simplification, I'm in doubt, that it is an efficient approach: You occupy 1.6GB memory with values, which are very easy to calculate dynamically.

Note: The reference "x(z,i,t)" requires two multiplications, while "i+z+t+2" uses 3 additions only.