why arrayfun does NOT improve my struct array operation performance

Question

HaveF 2012-6-23

0
链接

此问题的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/41876-why-arrayfun-does-not-improve-my-struct-array-operation-performance

here is the input data:

% @param Landmarks:
%           Landmarks should be 1*m struct. 
%           m is the number of training set.
%           Landmark(i).data is a n*2 matrix

old function:

function Landmarks=CenterOfGravity(Landmarks)
% align center of gravity
for i=1 : length(Landmarks)
    Landmarks(i).data=Landmarks(i).data - ones(size(Landmarks(i).data,1),1)...
        *mean(Landmarks(i).data);
end
end

new function which use arrayfun:

function [Landmarks] = center_to_gravity(Landmarks)
Landmarks = arrayfun(@(struct_data)...
                        struct('data', struct_data.data - repmat(mean(struct_data.data), [size(struct_data.data, 1), 1]))...
                                            ,Landmarks);
end %function center_to_gravity

when using profiler, I find the usage of time is NOT what I expected:

Function          Total Time    Self Time*
CenterOfGravity     0.011s  0.004 s
center_to_gravity   0.029s  0.001 s

Can someone tell me why?

0 个评论
显示 -2更早的评论隐藏 -2更早的评论

请先登录，再进行评论。

请先登录，再回答此问题。

Answer 1

Jan 2012-6-23

0
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/41876-why-arrayfun-does-not-improve-my-struct-array-operation-performance#answer_51590

在 MATLAB Online 中打开

ARRAYFUN is not more efficient than a FOR loop, because it has a FOR loop internally.

Another idea:

for i = 1 : length(Landmarks)
    data = Landmarks(i).data;
    Landmarks(i).data= bsxfun(@minus, data, sum(data, 1) / size(data, 1));
end

Reduce the repeated access to a field, SUM/LENGTH is faster than MEAN, BSXFUN avoid the creation of a temporary array.

Or:

for i = 1 : length(Landmarks)
    data = Landmarks(i).data;
    m = sum(data, 1) / size(data, 1);
    data(:, 1) = data(:, 1) - m(1);
    data(:, 2) = data(:, 2) - m(2);
    Landmarks(i).data = data;
end

3 个评论
显示 1更早的评论隐藏 1更早的评论

HaveF 2012-6-24

In terms of why, Pursuit's explanation seems reasonable.

HaveF 2012-6-24

编辑：Randy Souza 2012-7-2

http://stackoverflow.com/questions/11170089/why-arrayfun-does-not-improve-my-struct-array-operation-performance

请先登录，再进行评论。

Answer 2

Walter Roberson 2012-6-23

1
链接

此回答的直接链接

https://ww2.mathworks.cn/matlabcentral/answers/41876-why-arrayfun-does-not-improve-my-struct-array-operation-performance#answer_51602

Also, profile disables a number of optimizations, so you cannot use profiler to determine full execution rate. Try timeit

2 个评论
显示无隐藏无

HaveF 2012-6-24

Thanks for this great tip! I decide to use timeit when compare two methods, use profiler to determine the bottleneck of my program for its relative inaccuracy time.

HaveF 2012-6-24